feat: jukebox volume slider #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only ifdefing when necessary
rapito
pushed a commit
to rapito/Ishiiruka
that referenced
this pull request
Aug 31, 2023
* feat: jukebox volume slider * set min size on percent text * update to match new API * chore: update rust extensions * fix: playback builds * actually fix playback build this time only ifdefing when necessary * chore: update rust extensions * rollback rust extensions one commit * remove unnecessary function * UpdateJukebox -> SetJukebox * minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be updated while the game is running. compounds with the system volume slider