Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for thread data parsing. #481

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Conversation

emypar
Copy link
Contributor

@emypar emypar commented Nov 16, 2022

Provide access to /proc/PID/task/TID files, for thread specific values. Since such files have the same structure as /proc/PID/ ones, the data structures and the parsers for the latter may be reused.

@discordianfish, @pgier if you could take a look at this very basic PR, that would be appreciated. TIA

Provide access to /proc/PID/task/TID files, for thread specific values. Since
such files have the same structure as /proc/PID/ ones, the data structures and
the parsers for the latter may be reused.

Signed-off-by: Emy Parparita <emy.parparita@gmail.com>
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@emypar
Copy link
Contributor Author

emypar commented Dec 15, 2022

Great, LGTM!

Thank you, could you also merge it on my behalf or point me to ppl. that might be able to do so? I don't have write access.

@discordianfish
Copy link
Member

We need another maintaoner to approve /cc @pgier @SuperQ

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM.

thread.go Outdated Show resolved Hide resolved
thread_test.go Outdated Show resolved Hide resolved
Signed-off-by: Emy Parparita <emy.parparita@gmail.com>
@emypar
Copy link
Contributor Author

emypar commented Dec 17, 2022

Minor nit, otherwise LGTM.

Thank you, all done!

@SuperQ SuperQ merged commit 3433fa1 into prometheus:master Dec 17, 2022
@emypar
Copy link
Contributor Author

emypar commented Dec 19, 2022

Thank you all for making this happen.

jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
* Add support for thread data parsing.

Provide access to /proc/PID/task/TID files, for thread specific values. Since
such files have the same structure as /proc/PID/ ones, the data structures and
the parsers for the latter may be reused.

Signed-off-by: Emy Parparita <emy.parparita@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants