Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include-on-hold option to treat on-hold workflows as running in queue #13

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

tkoft
Copy link
Contributor

@tkoft tkoft commented Oct 18, 2023

Manual approval jobs in CircleCI often are used to block workflows. This change prevents later workflows from running while a previous one is still on hold for manual approval.

For pipelines that just need to ensure jobs don't run concurrently and don't care what order workflows finish in, this option is by default set to false (the current behavior).

@promiseofcake
Copy link
Owner

Thanks for the submission! I will run it through a test tomorrow and if it works we can merge it in!

@promiseofcake promiseofcake mentioned this pull request Oct 19, 2023
@tkoft
Copy link
Contributor Author

tkoft commented Oct 19, 2023

My bash incompetence is showing, went ahead and fixed those shellcheck errors :)

@promiseofcake
Copy link
Owner

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/promiseofcake/workflow-queue?version=dev:7090c13f3a244a163236bb22709710c6a34a9365

@promiseofcake
Copy link
Owner

promiseofcake commented Oct 24, 2023

@tkoft will you try to test out the preview orb #13 (comment) and let us know how it goes?

I also have allowed forks to run CI now so let's see if there are any additional changes that will kick off CI.

@promiseofcake promiseofcake added the enhancement New feature or request label Nov 9, 2023
@promiseofcake
Copy link
Owner

@tkoft , have you been able to verify this works as expected?

@promiseofcake promiseofcake merged commit 369a5f8 into promiseofcake:main Apr 13, 2024
7 checks passed
@promiseofcake
Copy link
Owner

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/promiseofcake/workflow-queue?version=dev:369a5f8361b0f99580f0d8ae52a4d895b328d2ef

1 similar comment
@promiseofcake
Copy link
Owner

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/promiseofcake/workflow-queue?version=dev:369a5f8361b0f99580f0d8ae52a4d895b328d2ef

@promiseofcake
Copy link
Owner

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/promiseofcake/workflow-queue?version=2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants