Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color printout does not respect TERM #148

Open
essen opened this issue Jul 10, 2017 · 4 comments
Open

Color printout does not respect TERM #148

essen opened this issue Jul 10, 2017 · 4 comments

Comments

@essen
Copy link

essen commented Jul 10, 2017

Looking into using Proper now and running into a minor issue. In a57a6c6 colors were added, with no apparent way to disable them.

In addition it does not respect the TERM environment variable which means that colors will be sent even to terminals that do not support coloring. This means that when redirecting this output to a file I get all the color escape codes instead of just the text.
@fenollp
Copy link
Contributor

fenollp commented May 28, 2018

Fixed in #150

@essen
Copy link
Author

essen commented May 28, 2018

Cheers.

@essen essen closed this as completed May 28, 2018
@kostis kostis reopened this May 28, 2018
@kostis
Copy link
Collaborator

kostis commented May 28, 2018

Why was this closed? AFAIK, #150 solved only part of the issue (added a disabling option). The TERM issue was not addressed. Or am I missing something?

I am re-opening the issue and will leave it open until a PropEr fix for it is found.

@essen
Copy link
Author

essen commented May 28, 2018

Because I've been using nocolors ever since and it works fine. But fair enough, if TERM can be properly supported then all the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@essen @kostis @fenollp