diff --git a/conformance/conformance_test_runner.cc b/conformance/conformance_test_runner.cc index 9c40b866c086..cb308f74d609 100644 --- a/conformance/conformance_test_runner.cc +++ b/conformance/conformance_test_runner.cc @@ -77,7 +77,7 @@ using std::vector; #define STRINGIFY(x) #x #define TOSTRING(x) STRINGIFY(x) -#define GOOGLE_CHECK_SYSCALL(call) \ +#define CHECK_SYSCALL(call) \ if (call < 0) { \ perror(#call " " __FILE__ ":" TOSTRING(__LINE__)); \ exit(1); \ @@ -289,22 +289,22 @@ void ForkPipeRunner::SpawnTestProgram() { if (pid) { // Parent. - GOOGLE_CHECK_SYSCALL(close(toproc_pipe_fd[0])); - GOOGLE_CHECK_SYSCALL(close(fromproc_pipe_fd[1])); + CHECK_SYSCALL(close(toproc_pipe_fd[0])); + CHECK_SYSCALL(close(fromproc_pipe_fd[1])); write_fd_ = toproc_pipe_fd[1]; read_fd_ = fromproc_pipe_fd[0]; child_pid_ = pid; } else { // Child. - GOOGLE_CHECK_SYSCALL(close(STDIN_FILENO)); - GOOGLE_CHECK_SYSCALL(close(STDOUT_FILENO)); - GOOGLE_CHECK_SYSCALL(dup2(toproc_pipe_fd[0], STDIN_FILENO)); - GOOGLE_CHECK_SYSCALL(dup2(fromproc_pipe_fd[1], STDOUT_FILENO)); + CHECK_SYSCALL(close(STDIN_FILENO)); + CHECK_SYSCALL(close(STDOUT_FILENO)); + CHECK_SYSCALL(dup2(toproc_pipe_fd[0], STDIN_FILENO)); + CHECK_SYSCALL(dup2(fromproc_pipe_fd[1], STDOUT_FILENO)); - GOOGLE_CHECK_SYSCALL(close(toproc_pipe_fd[0])); - GOOGLE_CHECK_SYSCALL(close(fromproc_pipe_fd[1])); - GOOGLE_CHECK_SYSCALL(close(toproc_pipe_fd[1])); - GOOGLE_CHECK_SYSCALL(close(fromproc_pipe_fd[0])); + CHECK_SYSCALL(close(toproc_pipe_fd[0])); + CHECK_SYSCALL(close(fromproc_pipe_fd[1])); + CHECK_SYSCALL(close(toproc_pipe_fd[1])); + CHECK_SYSCALL(close(fromproc_pipe_fd[0])); std::unique_ptr executable(new char[executable_.size() + 1]); memcpy(executable.get(), executable_.c_str(), executable_.size()); @@ -319,7 +319,7 @@ void ForkPipeRunner::SpawnTestProgram() { } argv.push_back(nullptr); // Never returns. - GOOGLE_CHECK_SYSCALL(execv(executable.get(), const_cast(argv.data()))); + CHECK_SYSCALL(execv(executable.get(), const_cast(argv.data()))); } } diff --git a/python/google/protobuf/pyext/descriptor.cc b/python/google/protobuf/pyext/descriptor.cc index f6db77a160fe..aa364744b818 100644 --- a/python/google/protobuf/pyext/descriptor.cc +++ b/python/google/protobuf/pyext/descriptor.cc @@ -32,6 +32,8 @@ #include "google/protobuf/pyext/descriptor.h" +#include "google/protobuf/stubs/logging.h" + #define PY_SSIZE_T_CLEAN #include #include @@ -404,7 +406,7 @@ PyObject* NewInternedDescriptor(PyTypeObject* type, std::unordered_map::iterator it = interned_descriptors->find(descriptor); if (it != interned_descriptors->end()) { - GOOGLE_DCHECK(Py_TYPE(it->second) == type); + GOOGLE_ABSL_DCHECK(Py_TYPE(it->second) == type); Py_INCREF(it->second); return it->second; } diff --git a/python/google/protobuf/pyext/descriptor_database.cc b/python/google/protobuf/pyext/descriptor_database.cc index 24689cdf90bc..f25443842ee5 100644 --- a/python/google/protobuf/pyext/descriptor_database.cc +++ b/python/google/protobuf/pyext/descriptor_database.cc @@ -37,8 +37,8 @@ #include #include -#include "google/protobuf/stubs/logging.h" #include "google/protobuf/descriptor.pb.h" +#include "google/protobuf/stubs/logging.h" #include "google/protobuf/pyext/message.h" #include "google/protobuf/pyext/scoped_pyobject_ptr.h" @@ -62,7 +62,7 @@ static bool GetFileDescriptorProto(PyObject* py_descriptor, // Expected error: item was simply not found. PyErr_Clear(); } else { - GOOGLE_LOG(ERROR) << "DescriptorDatabase method raised an error"; + GOOGLE_ABSL_LOG(ERROR) << "DescriptorDatabase method raised an error"; PyErr_Print(); } return false; @@ -86,7 +86,7 @@ static bool GetFileDescriptorProto(PyObject* py_descriptor, ScopedPyObjectPtr serialized_pb( PyObject_CallMethod(py_descriptor, "SerializeToString", nullptr)); if (serialized_pb == nullptr) { - GOOGLE_LOG(ERROR) + GOOGLE_ABSL_LOG(ERROR) << "DescriptorDatabase method did not return a FileDescriptorProto"; PyErr_Print(); return false; @@ -94,14 +94,14 @@ static bool GetFileDescriptorProto(PyObject* py_descriptor, char* str; Py_ssize_t len; if (PyBytes_AsStringAndSize(serialized_pb.get(), &str, &len) < 0) { - GOOGLE_LOG(ERROR) + GOOGLE_ABSL_LOG(ERROR) << "DescriptorDatabase method did not return a FileDescriptorProto"; PyErr_Print(); return false; } FileDescriptorProto file_proto; if (!file_proto.ParseFromArray(str, len)) { - GOOGLE_LOG(ERROR) + GOOGLE_ABSL_LOG(ERROR) << "DescriptorDatabase method did not return a FileDescriptorProto"; return false; } @@ -172,9 +172,8 @@ bool PyDescriptorDatabase::FindAllExtensionNumbers( ScopedPyObjectPtr item(PySequence_GetItem(py_list.get(), i)); item_value = PyLong_AsLong(item.get()); if (item_value < 0) { - GOOGLE_LOG(ERROR) - << "FindAllExtensionNumbers method did not return " - << "valid extension numbers."; + GOOGLE_ABSL_LOG(ERROR) << "FindAllExtensionNumbers method did not return " + << "valid extension numbers."; PyErr_Print(); return false; } diff --git a/python/google/protobuf/pyext/extension_dict.cc b/python/google/protobuf/pyext/extension_dict.cc index 287a4656174a..04a3d9131dd0 100644 --- a/python/google/protobuf/pyext/extension_dict.cc +++ b/python/google/protobuf/pyext/extension_dict.cc @@ -37,7 +37,6 @@ #include #include -#include "google/protobuf/stubs/logging.h" #include "google/protobuf/descriptor.pb.h" #include "google/protobuf/descriptor.h" #include "google/protobuf/dynamic_message.h" diff --git a/python/google/protobuf/pyext/map_container.cc b/python/google/protobuf/pyext/map_container.cc index 45c1f05483bb..7d690c1e91ca 100644 --- a/python/google/protobuf/pyext/map_container.cc +++ b/python/google/protobuf/pyext/map_container.cc @@ -36,7 +36,6 @@ #include #include -#include "google/protobuf/stubs/logging.h" #include "google/protobuf/map.h" #include "google/protobuf/map_field.h" #include "google/protobuf/message.h" @@ -125,27 +124,27 @@ static bool PythonToMapKey(MapContainer* self, PyObject* obj, MapKey* key) { self->parent_field_descriptor->message_type()->map_key(); switch (field_descriptor->cpp_type()) { case FieldDescriptor::CPPTYPE_INT32: { - GOOGLE_CHECK_GET_INT32(obj, value, false); + PROTOBUF_CHECK_GET_INT32(obj, value, false); key->SetInt32Value(value); break; } case FieldDescriptor::CPPTYPE_INT64: { - GOOGLE_CHECK_GET_INT64(obj, value, false); + PROTOBUF_CHECK_GET_INT64(obj, value, false); key->SetInt64Value(value); break; } case FieldDescriptor::CPPTYPE_UINT32: { - GOOGLE_CHECK_GET_UINT32(obj, value, false); + PROTOBUF_CHECK_GET_UINT32(obj, value, false); key->SetUInt32Value(value); break; } case FieldDescriptor::CPPTYPE_UINT64: { - GOOGLE_CHECK_GET_UINT64(obj, value, false); + PROTOBUF_CHECK_GET_UINT64(obj, value, false); key->SetUInt64Value(value); break; } case FieldDescriptor::CPPTYPE_BOOL: { - GOOGLE_CHECK_GET_BOOL(obj, value, false); + PROTOBUF_CHECK_GET_BOOL(obj, value, false); key->SetBoolValue(value); break; } @@ -231,37 +230,37 @@ static bool PythonToMapValueRef(MapContainer* self, PyObject* obj, self->parent_field_descriptor->message_type()->map_value(); switch (field_descriptor->cpp_type()) { case FieldDescriptor::CPPTYPE_INT32: { - GOOGLE_CHECK_GET_INT32(obj, value, false); + PROTOBUF_CHECK_GET_INT32(obj, value, false); value_ref->SetInt32Value(value); return true; } case FieldDescriptor::CPPTYPE_INT64: { - GOOGLE_CHECK_GET_INT64(obj, value, false); + PROTOBUF_CHECK_GET_INT64(obj, value, false); value_ref->SetInt64Value(value); return true; } case FieldDescriptor::CPPTYPE_UINT32: { - GOOGLE_CHECK_GET_UINT32(obj, value, false); + PROTOBUF_CHECK_GET_UINT32(obj, value, false); value_ref->SetUInt32Value(value); return true; } case FieldDescriptor::CPPTYPE_UINT64: { - GOOGLE_CHECK_GET_UINT64(obj, value, false); + PROTOBUF_CHECK_GET_UINT64(obj, value, false); value_ref->SetUInt64Value(value); return true; } case FieldDescriptor::CPPTYPE_FLOAT: { - GOOGLE_CHECK_GET_FLOAT(obj, value, false); + PROTOBUF_CHECK_GET_FLOAT(obj, value, false); value_ref->SetFloatValue(value); return true; } case FieldDescriptor::CPPTYPE_DOUBLE: { - GOOGLE_CHECK_GET_DOUBLE(obj, value, false); + PROTOBUF_CHECK_GET_DOUBLE(obj, value, false); value_ref->SetDoubleValue(value); return true; } case FieldDescriptor::CPPTYPE_BOOL: { - GOOGLE_CHECK_GET_BOOL(obj, value, false); + PROTOBUF_CHECK_GET_BOOL(obj, value, false); value_ref->SetBoolValue(value); return true; } @@ -274,7 +273,7 @@ static bool PythonToMapValueRef(MapContainer* self, PyObject* obj, return true; } case FieldDescriptor::CPPTYPE_ENUM: { - GOOGLE_CHECK_GET_INT32(obj, value, false); + PROTOBUF_CHECK_GET_INT32(obj, value, false); if (allow_unknown_enum_values) { value_ref->SetEnumValue(value); return true; diff --git a/python/google/protobuf/pyext/message.cc b/python/google/protobuf/pyext/message.cc index 108dd52ff266..ab9e9433ae84 100644 --- a/python/google/protobuf/pyext/message.cc +++ b/python/google/protobuf/pyext/message.cc @@ -42,6 +42,7 @@ #include #include +#include "google/protobuf/stubs/logging.h" #include "absl/strings/match.h" #ifndef PyVarObject_HEAD_INIT @@ -51,7 +52,6 @@ #define Py_TYPE(ob) (((PyObject*)(ob))->ob_type) #endif #include "google/protobuf/stubs/common.h" -#include "google/protobuf/stubs/logging.h" #include "google/protobuf/descriptor.pb.h" #include "google/protobuf/descriptor.h" #include "google/protobuf/message.h" @@ -252,10 +252,10 @@ static PyObject* New(PyTypeObject* type, PyObject* args, PyObject* kwargs) { if (WKT_classes == nullptr) { ScopedPyObjectPtr well_known_types( PyImport_ImportModule(PROTOBUF_PYTHON_INTERNAL ".well_known_types")); - GOOGLE_DCHECK(well_known_types != nullptr); + GOOGLE_ABSL_DCHECK(well_known_types != nullptr); WKT_classes = PyObject_GetAttrString(well_known_types.get(), "WKTBASES"); - GOOGLE_DCHECK(WKT_classes != nullptr); + GOOGLE_ABSL_DCHECK(WKT_classes != nullptr); } PyObject* well_known_class = PyDict_GetItemString( @@ -680,8 +680,8 @@ bool IsValidUTF8(PyObject* obj) { bool AllowInvalidUTF8(const FieldDescriptor* field) { return false; } PyObject* CheckString(PyObject* arg, const FieldDescriptor* descriptor) { - GOOGLE_DCHECK(descriptor->type() == FieldDescriptor::TYPE_STRING || - descriptor->type() == FieldDescriptor::TYPE_BYTES); + GOOGLE_ABSL_DCHECK(descriptor->type() == FieldDescriptor::TYPE_STRING || + descriptor->type() == FieldDescriptor::TYPE_BYTES); if (descriptor->type() == FieldDescriptor::TYPE_STRING) { if (!PyBytes_Check(arg) && !PyUnicode_Check(arg)) { FormatTypeError(arg, "bytes, unicode"); @@ -784,7 +784,7 @@ bool CheckFieldBelongsToMessage(const FieldDescriptor* field_descriptor, namespace cmessage { PyMessageFactory* GetFactoryForMessage(CMessage* message) { - GOOGLE_DCHECK(PyObject_TypeCheck(message, CMessage_Type)); + GOOGLE_ABSL_DCHECK(PyObject_TypeCheck(message, CMessage_Type)); return reinterpret_cast(Py_TYPE(message))->py_message_factory; } @@ -856,7 +856,7 @@ int AssureWritable(CMessage* self) { } // Toplevel messages are always mutable. - GOOGLE_DCHECK(self->parent); + GOOGLE_ABSL_DCHECK(self->parent); if (AssureWritable(self->parent) == -1) { return -1; @@ -988,7 +988,7 @@ int DeleteRepeatedField( } Arena* arena = Arena::InternalGetArenaForAllocation(message); - GOOGLE_DCHECK_EQ(arena, nullptr) + GOOGLE_ABSL_DCHECK_EQ(arena, nullptr) << "python protobuf is expected to be allocated from heap"; // Remove items, starting from the end. for (; length > to; length--) { @@ -1001,9 +1001,10 @@ int DeleteRepeatedField( // // To work around a debug hardening (PROTOBUF_FORCE_COPY_IN_RELEASE), // explicitly use UnsafeArenaReleaseLast. To not break rare use cases where - // arena is used, we fallback to ReleaseLast (but GOOGLE_DCHECK to find/fix it). + // arena is used, we fallback to ReleaseLast (but GOOGLE_ABSL_DCHECK to find/fix + // it). // - // Note that arena is likely null and GOOGLE_DCHECK and ReleaesLast might be + // Note that arena is likely null and GOOGLE_ABSL_DCHECK and ReleaesLast might be // redundant. The current approach takes extra cautious path not to disrupt // production. Message* sub_message = @@ -1268,8 +1269,8 @@ static void Dealloc(CMessage* self) { PyObject_ClearWeakRefs(reinterpret_cast(self)); } // At this point all dependent objects have been removed. - GOOGLE_DCHECK(!self->child_submessages || self->child_submessages->empty()); - GOOGLE_DCHECK(!self->composite_fields || self->composite_fields->empty()); + GOOGLE_ABSL_DCHECK(!self->child_submessages || self->child_submessages->empty()); + GOOGLE_ABSL_DCHECK(!self->composite_fields || self->composite_fields->empty()); delete self->child_submessages; delete self->composite_fields; if (self->unknown_field_set) { @@ -1714,7 +1715,7 @@ static PyObject* InternalSerializeToString( coded_out.SetSerializationDeterministic(deterministic); } self->message->SerializeWithCachedSizes(&coded_out); - GOOGLE_CHECK(!coded_out.HadError()); + GOOGLE_ABSL_CHECK(!coded_out.HadError()); return result; } @@ -2256,37 +2257,37 @@ int InternalSetNonOneofScalar( switch (field_descriptor->cpp_type()) { case FieldDescriptor::CPPTYPE_INT32: { - GOOGLE_CHECK_GET_INT32(arg, value, -1); + PROTOBUF_CHECK_GET_INT32(arg, value, -1); reflection->SetInt32(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_INT64: { - GOOGLE_CHECK_GET_INT64(arg, value, -1); + PROTOBUF_CHECK_GET_INT64(arg, value, -1); reflection->SetInt64(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_UINT32: { - GOOGLE_CHECK_GET_UINT32(arg, value, -1); + PROTOBUF_CHECK_GET_UINT32(arg, value, -1); reflection->SetUInt32(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_UINT64: { - GOOGLE_CHECK_GET_UINT64(arg, value, -1); + PROTOBUF_CHECK_GET_UINT64(arg, value, -1); reflection->SetUInt64(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_FLOAT: { - GOOGLE_CHECK_GET_FLOAT(arg, value, -1); + PROTOBUF_CHECK_GET_FLOAT(arg, value, -1); reflection->SetFloat(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_DOUBLE: { - GOOGLE_CHECK_GET_DOUBLE(arg, value, -1); + PROTOBUF_CHECK_GET_DOUBLE(arg, value, -1); reflection->SetDouble(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_BOOL: { - GOOGLE_CHECK_GET_BOOL(arg, value, -1); + PROTOBUF_CHECK_GET_BOOL(arg, value, -1); reflection->SetBool(message, field_descriptor, value); break; } @@ -2298,7 +2299,7 @@ int InternalSetNonOneofScalar( break; } case FieldDescriptor::CPPTYPE_ENUM: { - GOOGLE_CHECK_GET_INT32(arg, value, -1); + PROTOBUF_CHECK_GET_INT32(arg, value, -1); if (reflection->SupportsUnknownEnumValues()) { reflection->SetEnumValue(message, field_descriptor, value); } else { diff --git a/python/google/protobuf/pyext/message.h b/python/google/protobuf/pyext/message.h index 1b0172f9a4c9..7da52df75eba 100644 --- a/python/google/protobuf/pyext/message.h +++ b/python/google/protobuf/pyext/message.h @@ -287,46 +287,46 @@ PyObject* SetAllowOversizeProtos(PyObject* m, PyObject* arg); #define FIELD_IS_REPEATED(field_descriptor) \ ((field_descriptor)->label() == FieldDescriptor::LABEL_REPEATED) -#define GOOGLE_CHECK_GET_INT32(arg, value, err) \ - int32_t value; \ - if (!CheckAndGetInteger(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_INT32(arg, value, err) \ + int32_t value; \ + if (!CheckAndGetInteger(arg, &value)) { \ + return err; \ } -#define GOOGLE_CHECK_GET_INT64(arg, value, err) \ - int64_t value; \ - if (!CheckAndGetInteger(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_INT64(arg, value, err) \ + int64_t value; \ + if (!CheckAndGetInteger(arg, &value)) { \ + return err; \ } -#define GOOGLE_CHECK_GET_UINT32(arg, value, err) \ - uint32_t value; \ - if (!CheckAndGetInteger(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_UINT32(arg, value, err) \ + uint32_t value; \ + if (!CheckAndGetInteger(arg, &value)) { \ + return err; \ } -#define GOOGLE_CHECK_GET_UINT64(arg, value, err) \ - uint64_t value; \ - if (!CheckAndGetInteger(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_UINT64(arg, value, err) \ + uint64_t value; \ + if (!CheckAndGetInteger(arg, &value)) { \ + return err; \ } -#define GOOGLE_CHECK_GET_FLOAT(arg, value, err) \ - float value; \ - if (!CheckAndGetFloat(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_FLOAT(arg, value, err) \ + float value; \ + if (!CheckAndGetFloat(arg, &value)) { \ + return err; \ } -#define GOOGLE_CHECK_GET_DOUBLE(arg, value, err) \ - double value; \ - if (!CheckAndGetDouble(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_DOUBLE(arg, value, err) \ + double value; \ + if (!CheckAndGetDouble(arg, &value)) { \ + return err; \ } -#define GOOGLE_CHECK_GET_BOOL(arg, value, err) \ - bool value; \ - if (!CheckAndGetBool(arg, &value)) { \ - return err; \ +#define PROTOBUF_CHECK_GET_BOOL(arg, value, err) \ + bool value; \ + if (!CheckAndGetBool(arg, &value)) { \ + return err; \ } #define FULL_MODULE_NAME "google.protobuf.pyext._message" diff --git a/python/google/protobuf/pyext/repeated_composite_container.cc b/python/google/protobuf/pyext/repeated_composite_container.cc index e9a479469b45..cac8f1af6965 100644 --- a/python/google/protobuf/pyext/repeated_composite_container.cc +++ b/python/google/protobuf/pyext/repeated_composite_container.cc @@ -35,7 +35,6 @@ #include -#include "google/protobuf/stubs/logging.h" #include "google/protobuf/descriptor.h" #include "google/protobuf/dynamic_message.h" #include "google/protobuf/message.h" diff --git a/python/google/protobuf/pyext/repeated_scalar_container.cc b/python/google/protobuf/pyext/repeated_scalar_container.cc index 57746dcf7705..b19f00491db4 100644 --- a/python/google/protobuf/pyext/repeated_scalar_container.cc +++ b/python/google/protobuf/pyext/repeated_scalar_container.cc @@ -38,7 +38,6 @@ #include #include "google/protobuf/stubs/common.h" -#include "google/protobuf/stubs/logging.h" #include "google/protobuf/descriptor.h" #include "google/protobuf/dynamic_message.h" #include "google/protobuf/message.h" @@ -109,37 +108,37 @@ static int AssignItem(PyObject* pself, Py_ssize_t index, PyObject* arg) { switch (field_descriptor->cpp_type()) { case FieldDescriptor::CPPTYPE_INT32: { - GOOGLE_CHECK_GET_INT32(arg, value, -1); + PROTOBUF_CHECK_GET_INT32(arg, value, -1); reflection->SetRepeatedInt32(message, field_descriptor, index, value); break; } case FieldDescriptor::CPPTYPE_INT64: { - GOOGLE_CHECK_GET_INT64(arg, value, -1); + PROTOBUF_CHECK_GET_INT64(arg, value, -1); reflection->SetRepeatedInt64(message, field_descriptor, index, value); break; } case FieldDescriptor::CPPTYPE_UINT32: { - GOOGLE_CHECK_GET_UINT32(arg, value, -1); + PROTOBUF_CHECK_GET_UINT32(arg, value, -1); reflection->SetRepeatedUInt32(message, field_descriptor, index, value); break; } case FieldDescriptor::CPPTYPE_UINT64: { - GOOGLE_CHECK_GET_UINT64(arg, value, -1); + PROTOBUF_CHECK_GET_UINT64(arg, value, -1); reflection->SetRepeatedUInt64(message, field_descriptor, index, value); break; } case FieldDescriptor::CPPTYPE_FLOAT: { - GOOGLE_CHECK_GET_FLOAT(arg, value, -1); + PROTOBUF_CHECK_GET_FLOAT(arg, value, -1); reflection->SetRepeatedFloat(message, field_descriptor, index, value); break; } case FieldDescriptor::CPPTYPE_DOUBLE: { - GOOGLE_CHECK_GET_DOUBLE(arg, value, -1); + PROTOBUF_CHECK_GET_DOUBLE(arg, value, -1); reflection->SetRepeatedDouble(message, field_descriptor, index, value); break; } case FieldDescriptor::CPPTYPE_BOOL: { - GOOGLE_CHECK_GET_BOOL(arg, value, -1); + PROTOBUF_CHECK_GET_BOOL(arg, value, -1); reflection->SetRepeatedBool(message, field_descriptor, index, value); break; } @@ -151,7 +150,7 @@ static int AssignItem(PyObject* pself, Py_ssize_t index, PyObject* arg) { break; } case FieldDescriptor::CPPTYPE_ENUM: { - GOOGLE_CHECK_GET_INT32(arg, value, -1); + PROTOBUF_CHECK_GET_INT32(arg, value, -1); if (reflection->SupportsUnknownEnumValues()) { reflection->SetRepeatedEnumValue(message, field_descriptor, index, value); @@ -334,37 +333,37 @@ PyObject* Append(RepeatedScalarContainer* self, PyObject* item) { const Reflection* reflection = message->GetReflection(); switch (field_descriptor->cpp_type()) { case FieldDescriptor::CPPTYPE_INT32: { - GOOGLE_CHECK_GET_INT32(item, value, nullptr); + PROTOBUF_CHECK_GET_INT32(item, value, nullptr); reflection->AddInt32(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_INT64: { - GOOGLE_CHECK_GET_INT64(item, value, nullptr); + PROTOBUF_CHECK_GET_INT64(item, value, nullptr); reflection->AddInt64(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_UINT32: { - GOOGLE_CHECK_GET_UINT32(item, value, nullptr); + PROTOBUF_CHECK_GET_UINT32(item, value, nullptr); reflection->AddUInt32(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_UINT64: { - GOOGLE_CHECK_GET_UINT64(item, value, nullptr); + PROTOBUF_CHECK_GET_UINT64(item, value, nullptr); reflection->AddUInt64(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_FLOAT: { - GOOGLE_CHECK_GET_FLOAT(item, value, nullptr); + PROTOBUF_CHECK_GET_FLOAT(item, value, nullptr); reflection->AddFloat(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_DOUBLE: { - GOOGLE_CHECK_GET_DOUBLE(item, value, nullptr); + PROTOBUF_CHECK_GET_DOUBLE(item, value, nullptr); reflection->AddDouble(message, field_descriptor, value); break; } case FieldDescriptor::CPPTYPE_BOOL: { - GOOGLE_CHECK_GET_BOOL(item, value, nullptr); + PROTOBUF_CHECK_GET_BOOL(item, value, nullptr); reflection->AddBool(message, field_descriptor, value); break; } @@ -376,7 +375,7 @@ PyObject* Append(RepeatedScalarContainer* self, PyObject* item) { break; } case FieldDescriptor::CPPTYPE_ENUM: { - GOOGLE_CHECK_GET_INT32(item, value, nullptr); + PROTOBUF_CHECK_GET_INT32(item, value, nullptr); if (reflection->SupportsUnknownEnumValues()) { reflection->AddEnumValue(message, field_descriptor, value); } else { diff --git a/python/google/protobuf/pyext/safe_numerics.h b/python/google/protobuf/pyext/safe_numerics.h index a3bcfc370d20..418473bf28cd 100644 --- a/python/google/protobuf/pyext/safe_numerics.h +++ b/python/google/protobuf/pyext/safe_numerics.h @@ -152,7 +152,7 @@ inline bool IsValidNumericCast(Source source) { // (this is static_asserted), though this could be supported if necessary. template inline Dest checked_numeric_cast(Source source) { - GOOGLE_CHECK(IsValidNumericCast(source)); + GOOGLE_ABSL_CHECK(IsValidNumericCast(source)); return static_cast(source); } diff --git a/src/google/protobuf/io/coded_stream.cc b/src/google/protobuf/io/coded_stream.cc index f47c3fd09b42..ef623ea281c1 100644 --- a/src/google/protobuf/io/coded_stream.cc +++ b/src/google/protobuf/io/coded_stream.cc @@ -324,7 +324,7 @@ bool CodedInputStream::ReadStringFallback(std::string* buffer, int size) { } bool CodedInputStream::ReadCord(absl::Cord* output, int size) { - GOOGLE_DCHECK_NE(output, nullptr); + GOOGLE_ABSL_DCHECK_NE(output, nullptr); // security: size is often user-supplied if (size < 0) { diff --git a/src/google/protobuf/io/printer.cc b/src/google/protobuf/io/printer.cc index ace56b124431..5ec2fafdb0ba 100644 --- a/src/google/protobuf/io/printer.cc +++ b/src/google/protobuf/io/printer.cc @@ -254,7 +254,7 @@ Printer::Format Printer::TokenizeFormat(absl::string_view format_string, } #if 0 // Use this to aid debugging tokenization. - GOOGLE_LOG(INFO) << "--- " << format.lines.size() << " lines"; + LOG(INFO) << "--- " << format.lines.size() << " lines"; for (size_t i = 0; i < format.lines.size(); ++i) { const auto& line = format.lines[i]; @@ -263,9 +263,9 @@ Printer::Format Printer::TokenizeFormat(absl::string_view format_string, absl::StrAppendFormat(&log_line, " %s\"%s\"", chunk.is_var ? "$" : "", absl::CHexEscape(chunk.text)); } - GOOGLE_LOG(INFO) << log_line; + LOG(INFO) << log_line; } - GOOGLE_LOG(INFO) << "---"; + LOG(INFO) << "---"; #endif return format;