Expose plugin protos for C# #10244
Merged
Expose plugin protos for C# #10244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The proto has been in production use for a long time now.)
This used to be infeasible as we didn't expose the descriptor protos, but it's fine now. Tested against https://github.com/googleapis/gapic-generator-csharp by removing the local version there. Fixes protocolbuffers#5007.
fowles
approved these changes
Jul 12, 2022
|
@fowles: I appear not to have write access to the repo any more - are you happy to merge this now it's green? (We can work out access separately...) |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Expose plugin protos for C#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here is just tidying up, effectively, and doesn't require a release note.
The second commit is the important one, exposing the plugin protos under the namespace Google.Protobuf.Compiler. This will be a semi-breaking change (generating a warning) for any project which already generates their own local copy of this proto, but is easily fixed by simply removing the local copy.