Use release version instead of libtool version in Makefile

[deannagarcia]

Fixes #10323

[fowles]

do we need to udpate the update_version.py to hit this line?

[deannagarcia]

Yep but needs to happen internally, I have filed a bug and CL will come soon.

[jengelh]

You can just use -release ${PACKAGE_VERSION} at which point only configure.ac needs updating.

[deannagarcia]

Where is PACKAGE_VERSION set?

[jengelh]

Either of the two answers should help:

AC_INIT([Protocol Buffers],[3.21.4],[protobuf@googlegroups.com],[protobuf])
                            ^^^^^^

or

grep -r PACKAGE_VERSION /usr/share/aut*
/usr/share/autoconf/autoconf/general.m4:AC_SUBST([PACKAGE_VERSION],

it's implied.

[acozzette]

I think we also need to make the corresponding change for CMake. libprotobuf.cmake, libprotobuf-lite.cmake, and libprotoc.cmake all set SOVERSION and it looks like we could probably update them to set VERSION instead: https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html

[deannagarcia]

I think we also need to make the corresponding change for CMake. libprotobuf.cmake, libprotobuf-lite.cmake, and libprotoc.cmake all set SOVERSION and it looks like we could probably update them to set VERSION instead: https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html

I made this change but I'm going to hold on submitting until we talk about whether protoc should share cpp's major version or have its own.