Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc: validate custom json_name configuration #10581

Merged
merged 7 commits into from
Sep 22, 2022
Merged

protoc: validate custom json_name configuration #10581

merged 7 commits into from
Sep 22, 2022

Commits on Sep 14, 2022

  1. add check for custom JSON name conflicts 

    - also, include check for default JSON name conflicts even in proto2
  files (but only warn)
- if custom JSON name conflicts with other default name, only a
  warning in proto2
    @jhump
    jhump committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c23d0b8 View commit details
    Browse the repository at this point in the history

  2. update existing test expectations and add new tests

    @jhump
    jhump committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    cbd5c84 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. JSON -> Json

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    7c57fb0 View commit details
    Browse the repository at this point in the history

  2. address review feedback wrt absl string functions 

    also moves helpers into anonymous namespace
    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    16627c5 View commit details
    Browse the repository at this point in the history

  3. apply clang-format changes; change really long pair type to auto

    @jhump
    jhump committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    d86340e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. address review feedback

    @jhump
    jhump committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    8e74523 View commit details
    Browse the repository at this point in the history

  2. return struct instead of using out param

    @jhump
    jhump committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    c7ba055 View commit details
    Browse the repository at this point in the history