Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forward slash instead of backslash in nuspec file #11449

Closed
wants to merge 1 commit into from
Closed

Use forward slash instead of backslash in nuspec file #11449

wants to merge 1 commit into from

Conversation

deannagarcia
Copy link
Member

We are going to pack this on a linux machine now, so we need to use forward slashes.

@deannagarcia
Use forward slash instead of backslash in nuspec file
24a4ecf 
We are going to pack this on a linux machine now, so we need to use forward slashes.
@deannagarcia deannagarcia requested a review from a team as a code owner January 3, 2023 23:49
@deannagarcia deannagarcia requested review from jskeet and perezd and removed request for a team and jskeet January 3, 2023 23:49
@deannagarcia deannagarcia added the mergeable:force-allow Break-glass label to allow merging PRs directly without Copybara. label Jan 4, 2023
@deannagarcia deannagarcia requested review from fowles and jskeet and removed request for fowles January 4, 2023 00:31
jskeet
jskeet approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly surprised that the tooling doesn't already handle this (as it does for things like project references) but it won't do any harm to use forward slashes.

@copybara-service copybara-service bot closed this in 724250d Jan 4, 2023
@zhangskz zhangskz deleted the deannagarcia-patch-16 branch February 10, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@perezd perezd perezd approved these changes

Assignees
No one assigned
Labels
c# mergeable:force-allow Break-glass label to allow merging PRs directly without Copybara. packaging & distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deannagarcia @jskeet @perezd