Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in string(JOIN) workaround #12698

Closed
wants to merge 1 commit into from
Closed

fix: typo in string(JOIN) workaround #12698

wants to merge 1 commit into from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 6, 2023

My sketch to fix #12672 was wrong. This works for realsies.

@coryan coryan marked this pull request as ready for review May 6, 2023 21:59
@coryan coryan requested a review from a team as a code owner May 6, 2023 21:59
@coryan coryan requested review from haberman and removed request for a team May 6, 2023 21:59
@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 7, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 7, 2023
@copybara-service copybara-service bot closed this in 5613ab0 May 7, 2023
@coryan coryan deleted the fix-cmake-typo-in-string-join-workaround branch May 7, 2023 16:33
@coryan coryan mentioned this pull request May 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fowles fowles fowles approved these changes

@haberman haberman Awaiting requested review from haberman haberman is a code owner automatically assigned from protocolbuffers/protobuf-btr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake files use string(JOIN) while only requesting CMake >= 3.5
2 participants
@coryan @fowles