Make our Python source wheel use the version script to restruct symbol visibility. #17207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…l visibility. We generally want our extension module to hide all symbols except a single entry point, `PyInit__message()`. We accomplish this through a `version_script.lds`, which instructs the linker to hide all symbols except our single entry point. Currently, only our Bazel-based build is using `version_script.lds`. This CL makes our Python source package also use `version_script.lds`, so that it can produce binary wheel that are more similar to the Bazel-built ones that we release. PiperOrigin-RevId: 645445353
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make our Python source wheel use the version script to restruct symbol visibility.
We generally want our extension module to hide all symbols except a single entry point,
PyInit__message(). We accomplish this through aversion_script.lds, which instructs the linker to hide all symbols except our single entry point.Currently, only our Bazel-based build is using
version_script.lds. This CL makes our Python source package also useversion_script.lds, so that it can produce binary wheel that are more similar to the Bazel-built ones that we release.