Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gov proposal support for IBC client update #1670

Closed
4 tasks
jtalis opened this issue Sep 6, 2023 · 2 comments
Closed
4 tasks

Gov proposal support for IBC client update #1670

jtalis opened this issue Sep 6, 2023 · 2 comments
Assignees
Labels
ibc inter-blockchain communication
Milestone

Comments

@jtalis
Copy link
Contributor

jtalis commented Sep 6, 2023

Summary

Add support for ibc.core.client.v1.ClientUpdateProposal using gov submit-proposal

Problem Definition

When attempting to submit an IBC client update governance proposal using provenanced tx gov submit-proposal, an error is thrown Error: no concrete type registered for type URL /ibc.core.client.v1.ClientUpdateProposal against interface *types.Msg.

The following proposal json was attempted:

{
  "messages": [
    {
      "@type": "/ibc.core.client.v1.ClientUpdateProposal",
      "title": "unfreeze FES zone client",
      "description": "unfreeze expired FES zone client",
      "subject_client_id": "07-tendermint-64",
      "substitute_client_id": "07-tendermint-75"
    }
  ],
  "deposit": "1nhash"

Submitting the proposal using the submit legacy path works fine. See https://explorer.test.provenance.io/tx/AEB84C595871E0F009309E6CE3815E1F345E88DEFC5F299959998E05674CDDD8/17341185 for an example of the proposal submitted using the legacy flow.

Proposal

Add support for ibc.core.client.v1.ClientUpdateProposal using gov submit-proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added this to the v1.17.0 milestone Sep 6, 2023
@iramiller iramiller added the ibc inter-blockchain communication label Sep 6, 2023
@nullpointer0x00
Copy link
Contributor

nullpointer0x00 commented Oct 13, 2023

ibc.core.client.v1.ClientUpdateProposal cannot be supported by gov submit-proposal since it is not of type sdk.Msg. It implements the legacy proposal type. You will have to continue using the legacy path for now.
In a future version (v.8.0.0) ibc-go will be deprecating the ibc.core.client.v1.ClientUpdateProposal and moving to the new sdk.Msg MsgRecoverClient instead that can be used with the gov submit-proposal method. https://github.com/cosmos/ibc-go/blob/0d524eca07e0a99519356f1767c5c4c267a31779/proto/ibc/core/client/v1/client.proto#L72C27-L72C43

@jtalis I would continue using the legacy method for submitting those proposals and plan on moving to MsgRecoverClient in a future release.

@nullpointer0x00
Copy link
Contributor

The new msgs will be implemented in provenance when this issue is completed: #1707

For more details on ibc-go change: cosmos/ibc-go#4620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibc inter-blockchain communication
Projects
Development

No branches or pull requests

3 participants