Line splitting on conditional operators should take precendence over splitting on function parameters

[ovidiu-munteanu]

Black should split conditionals at conditional operators (i.e. and, or, etc.) when possible, instead of splitting function parameters over multiple lines.

Currently, this is how black formats a long conditional:

if str(
    self.user.id
) != self.target_user_id and not CheckUserManagementViewPermission.user_has_permission(
    self.user
):
    pass

Ideally, it should be formatted like this:

if (
    str(self.user.id) != self.target_user_id
    and not CheckUserManagementViewPermission.user_has_permission(
        self.user
    )
):
    pass

This appears to be a general issue with splitting conditionals and it looks like it's related to these issues: #815 #1050

[felix-hilden]

I'll close this as a duplicate of #2156, and add this specific case there.

[ambv]

I'll re-open this because those cases are not the same. This case is for more than one operator in the mix.

[felix-hilden]

Oh, fair enough 👍 at least they're linked now.