Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back to web fetch #16

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

sigma-andex
Copy link

Description of the change

PR to merge back rowtype-yoga/purescript-fetch-core to purescript-web/web-streams so we can then transfer it to purescript-contrib as purescript-js-fetch.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@garyb
Copy link
Member

garyb commented Sep 24, 2023

There are a few mentions of rowtype-yoga and fetch-core in here still in the readme/bower/spago files.

I'd prefer if we dropped the Core part of the namespacing too, since we're calling this purescript-js-fetch. I realise that'll conflict with rowtype-yoga/purescript-fetch, but since that's a higher level/opinionated library I don't think it should get to take the basic namespace.

@sigma-andex
Copy link
Author

I'd prefer if we dropped the Core part of the namespacing too, since we're calling this purescript-js-fetch. I realise that'll conflict with rowtype-yoga/purescript-fetch, but since that's a higher level/opinionated library I don't think it should get to take the basic namespace.

we could use JS.Fetch like we did with purescript-js-bigint and purescript-js-blob.

@garyb
Copy link
Member

garyb commented Sep 24, 2023

Sure, that works. I do feel like just Fetch would be the most ideal (like Promise), but since there are also examples of JS being included sometimes I guess it's fine either way. 😉

@sigma-andex
Copy link
Author

Ok I created purescript-js-fetch with the changes and renaming to JS.Fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants