From 0c4b97215d86b4f621a791d6ed075c4e5e967a59 Mon Sep 17 00:00:00 2001 From: Valentin Sulzer Date: Tue, 23 Aug 2022 23:18:40 +0100 Subject: [PATCH] fix examples --- examples/notebooks/models/using-submodels.ipynb | 14 +++++++------- examples/scripts/custom_model.py | 4 ++-- .../models/full_battery_models/lithium_ion/spm.py | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/examples/notebooks/models/using-submodels.ipynb b/examples/notebooks/models/using-submodels.ipynb index eefe7df315..e7eb75704d 100644 --- a/examples/notebooks/models/using-submodels.ipynb +++ b/examples/notebooks/models/using-submodels.ipynb @@ -138,7 +138,7 @@ "outputs": [], "source": [ "model.submodels[\"negative primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(\n", - " model.param, \"Negative\", options={**model.options, \"particle\": \"uniform profile\"}, phase=\"primary\"\n", + " model.param, \"Negative\", options={**model.options, \"particle\": \"uniform profile\"}\n", ")" ] }, @@ -416,8 +416,8 @@ "outputs": [], "source": [ "options = {**model.options, \"particle\": \"uniform profile\"}\n", - "model.submodels[\"negative primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Negative\", options, \"primary\")\n", - "model.submodels[\"positive primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Positive\", options, \"primary\")" + "model.submodels[\"negative primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Negative\", options)\n", + "model.submodels[\"positive primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Positive\", options)" ] }, { @@ -436,12 +436,12 @@ "model.submodels[\n", " \"negative open circuit potential\"\n", "] = pybamm.open_circuit_potential.SingleOpenCircuitPotential(\n", - " model.param, \"Negative\", \"lithium-ion main\", options=model.options, phase=\"primary\"\n", + " model.param, \"Negative\", \"lithium-ion main\", options=model.options\n", ")\n", "model.submodels[\n", " \"positive open circuit potential\"\n", "] = pybamm.open_circuit_potential.SingleOpenCircuitPotential(\n", - " model.param, \"Positive\", \"lithium-ion main\", options=model.options, phase=\"primary\"\n", + " model.param, \"Positive\", \"lithium-ion main\", options=model.options\n", ")\n", "model.submodels[\n", " \"negative interface\"\n", @@ -486,10 +486,10 @@ "source": [ "model.submodels[\n", " \"Negative particle mechanics\"\n", - "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Negative\", model.options, \"primary\")\n", + "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Negative\", model.options)\n", "model.submodels[\n", " \"Positive particle mechanics\"\n", - "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Positive\", model.options, \"primary\")\n", + "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Positive\", model.options)\n", "model.submodels[\"sei\"] = pybamm.sei.NoSEI(model.param)\n", "model.submodels[\"sei on cracks\"] = pybamm.sei.NoSEI(model.param, cracks=True)\n", "model.submodels[\"lithium plating\"] = pybamm.lithium_plating.NoPlating(model.param)" diff --git a/examples/scripts/custom_model.py b/examples/scripts/custom_model.py index a6e137d6ad..56c4fa098b 100644 --- a/examples/scripts/custom_model.py +++ b/examples/scripts/custom_model.py @@ -93,10 +93,10 @@ model.param, "Positive" ) model.submodels["Negative particle mechanics"] = pybamm.particle_mechanics.NoMechanics( - model.param, "Negative", model.options, "primary" + model.param, "Negative", model.options ) model.submodels["Positive particle mechanics"] = pybamm.particle_mechanics.NoMechanics( - model.param, "Positive", model.options, "primary" + model.param, "Positive", model.options ) model.submodels["sei"] = pybamm.sei.NoSEI(model.param) model.submodels["sei on cracks"] = pybamm.sei.NoSEI(model.param, cracks=True) diff --git a/pybamm/models/full_battery_models/lithium_ion/spm.py b/pybamm/models/full_battery_models/lithium_ion/spm.py index 8d15c717fe..1cefa8c915 100644 --- a/pybamm/models/full_battery_models/lithium_ion/spm.py +++ b/pybamm/models/full_battery_models/lithium_ion/spm.py @@ -106,7 +106,7 @@ def set_intercalation_kinetics_submodel(self): self.param, domain, "lithium-ion main", self.options, phase ) - self.submodels[f"{domain} {phase} interface"] = submod + self.submodels[f"{domain} {phase} interface"] = submod if len(phases) > 1: self.submodels[ f"total {domain} interface"