diff --git a/.github/workflows/run_periodic_tests.yml b/.github/workflows/run_periodic_tests.yml index 5b3fedd6c8..dec5de094b 100644 --- a/.github/workflows/run_periodic_tests.yml +++ b/.github/workflows/run_periodic_tests.yml @@ -102,7 +102,7 @@ jobs: - name: Upload coverage report if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.11 - uses: codecov/codecov-action@v4.1.1 + uses: codecov/codecov-action@v4.2.0 with: token: ${{ secrets.CODECOV_TOKEN }} diff --git a/.github/workflows/test_on_push.yml b/.github/workflows/test_on_push.yml index b5b6ec0de4..e97cb76603 100644 --- a/.github/workflows/test_on_push.yml +++ b/.github/workflows/test_on_push.yml @@ -174,7 +174,7 @@ jobs: run: python -m nox -s coverage - name: Upload coverage report - uses: codecov/codecov-action@v4.1.1 + uses: codecov/codecov-action@v4.2.0 with: token: ${{ secrets.CODECOV_TOKEN }} diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5f971c7a7c..5861324503 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -19,7 +19,7 @@ repos: additional_dependencies: [black==23.*] - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.5.0 + rev: v4.6.0 hooks: - id: check-added-large-files - id: check-case-conflict diff --git a/pybamm/solvers/base_solver.py b/pybamm/solvers/base_solver.py index fb4865358d..82d6159769 100644 --- a/pybamm/solvers/base_solver.py +++ b/pybamm/solvers/base_solver.py @@ -710,16 +710,16 @@ def solve( The model whose solution to calculate. Must have attributes rhs and initial_conditions. All calls to solve must pass in the same model or an error is raised - t_eval : numeric type - The times (in seconds) at which to compute the solution + t_eval : None, list or ndarray, optional + The times (in seconds) at which to compute the solution. Defaults to None. inputs : dict or list, optional A dictionary or list of dictionaries describing any input parameters to pass to the model when solving nproc : int, optional Number of processes to use when solving for more than one set of input parameters. Defaults to value returned by "os.cpu_count()". - calculate_sensitivities : list of str or bool - If true, solver calculates sensitivities of all input parameters. + calculate_sensitivities : list of str or bool, optional + Whether the solver calculates sensitivities of all input parameters. Defaults to False. If only a subset of sensitivities are required, can also pass a list of input parameter names @@ -1117,9 +1117,8 @@ def step( npts : deprecated inputs : dict, optional Any input parameters to pass to the model when solving - save : bool - Turn on to store the solution of all previous timesteps - + save : bool, optional + Save solution with all previous timesteps. Defaults to True. Raises ------ :class:`pybamm.ModelError`