From e52a1bba5a67f0cf1c8876e8ef78716faa7d36b1 Mon Sep 17 00:00:00 2001 From: Valentin Sulzer Date: Wed, 17 Nov 2021 14:28:11 -0500 Subject: [PATCH] fix tests --- pybamm/models/full_battery_models/base_battery_model.py | 3 +++ .../test_lead_acid/test_base_lead_acid_model.py | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/pybamm/models/full_battery_models/base_battery_model.py b/pybamm/models/full_battery_models/base_battery_model.py index 8270174825..fe01a0baaa 100644 --- a/pybamm/models/full_battery_models/base_battery_model.py +++ b/pybamm/models/full_battery_models/base_battery_model.py @@ -848,6 +848,9 @@ def set_thermal_submodel(self): thermal_submodel = pybamm.thermal.pouch_cell.CurrentCollector2D( self.param ) + elif self.options["thermal"] == "x-full": + if self.options["dimensionality"] == 0: + thermal_submodel = pybamm.thermal.OneDimensionalX(self.param) self.submodels["thermal"] = thermal_submodel diff --git a/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py b/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py index 650d957501..6d5da98fce 100644 --- a/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py +++ b/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py @@ -19,11 +19,6 @@ def test_default_geometry(self): self.assertEqual(model.default_geometry["current collector"][var.y]["min"], 0) def test_incompatible_options(self): - with self.assertRaisesRegex( - pybamm.OptionError, - "Lead-acid models can only have thermal effects if dimensionality is 0.", - ): - pybamm.lead_acid.BaseModel({"dimensionality": 1, "thermal": "x-full"}) with self.assertRaisesRegex(pybamm.OptionError, "SEI"): pybamm.lead_acid.BaseModel({"SEI": "constant"}) with self.assertRaisesRegex(pybamm.OptionError, "lithium plating"):