Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI tests are not run on PRs from forks #1012

Closed
valentinsulzer opened this issue May 21, 2020 · 4 comments · Fixed by #1013
Closed

CI tests are not run on PRs from forks #1012

valentinsulzer opened this issue May 21, 2020 · 4 comments · Fixed by #1013
Assignees
@tlestang

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented May 21, 2020 •
edited
Loading

When a PR is made from a fork, the CI tests on GitHub actions do not start. See #1009 and #1010 for example. I don't know if this is due to a temporary outage or a bug in the workflow

@tlestang @dalonsoa
@dalonsoa dalonsoa mentioned this issue May 21, 2020
Merged
8 tasks
@dalonsoa
Copy link
Contributor

Sorry! I dind't realised this was assigned to @tlestang and have open a PR with - I think - the solution.

@tlestang
Copy link
Contributor

No worries! I'm just finding out about this issue :)

@tlestang
Copy link
Contributor

I guess CI was only triggered by pushes?

@dalonsoa
Copy link
Contributor

dalonsoa commented May 21, 2020 •
edited
Loading

Yes, that was the issue. I've just added pull_request to trigger it also when there's a PR. In principle, it will trigger when there's a PR against ANY branch, but I guess in practice it will be just develop and, from time to time, master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlestang tlestang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger GitHub Actions on PR dalonsoa/PyBaMM
3 participants
@dalonsoa @tlestang @valentinsulzer