Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "experiment" parameter folder #2077

Closed
valentinsulzer opened this issue May 26, 2022 · 1 comment · Fixed by #2342
Closed

Remove "experiment" parameter folder #2077

valentinsulzer opened this issue May 26, 2022 · 1 comment · Fixed by #2342

Comments

@valentinsulzer
Copy link
Member

Having this as a separate parameter folder is redundant, it could be merged with the "cells" folder.
I thought a useful workflow would be to switch in and out different "experiment" subfolders, but I think people are just modifying the parameters dictionary in scripts instead.
@valentinsulzer
Copy link
Member Author

Irrelevant if we do #2334 (which is quite likely, so closing)

@valentinsulzer valentinsulzer mentioned this issue Oct 6, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 2334 reformat parameters pybamm-team/PyBaMM
1 participant
@valentinsulzer