Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conserve needs-reply GitHub Actions workflow runs #3743

Closed
agriyakhetarpal opened this issue Jan 18, 2024 · 4 comments · Fixed by #3891
Closed

Conserve needs-reply GitHub Actions workflow runs #3743

agriyakhetarpal opened this issue Jan 18, 2024 · 4 comments · Fixed by #3891
Labels
CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@agriyakhetarpal
Copy link
Member

The needs-reply workflow currently runs on all issue comments or PR comments and it runs too much: https://github.com/pybamm-team/PyBaMM/actions/workflows/need_reply_remove.yml

I am not sure as to how to fix this as of now, and we don't mind it at all (GitHub Actions is completely free for public repositories) but it would be great if the runs for this workflow could be limited in some way or form. Some suggestions could be to:

  1. Run only on stale conversations or on different events
  2. Switch to a different GitHub App or GitHub Action
  3. Skip the workflow on PRs
  4. Remove the workflow altogether
  5. and so on
@agriyakhetarpal agriyakhetarpal added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) labels Jan 18, 2024
@santacodes
Copy link
Contributor

Maybe we could schedule it to run on a specific interval using cron job but I am not sure how much of an interval would be ideal for this particular action.

@agriyakhetarpal
Copy link
Member Author

Yes, that makes sense. How much would you expect it should run?

I would say we can run it weekly on Sunday (or thrice weekly on Monday, Wednesday, and Friday perhaps or would that be too much?), and skip it on un-labelled issues. Also, it should not run at all on PRs, since we use the needs-reply label only for issues.

The reason for the addition of the needs-reply label was was to mark issues for closing after thirty days of labelling that are without a response after the duration, so I think the minimum cadence should be at least fortnightly.

@santacodes
Copy link
Contributor

A weekly run would be fair if the frequency of issues created are less, or we could maybe do it twice a week.

@agriyakhetarpal
Copy link
Member Author

A weekly run sounds good to me. We can also customise the granularity based on other GitHub Issue events (while keeping it as minimal as possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants