-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roadmap area] Solver improvements #3910
Comments
Not solver, but this is related to speed-up: #4058 |
This is my attempt at a roadmap for PyBaMM's solvers, comments / suggestions welcome Sensitivities
Multithreaded/GPU support:
Post Processing optimisation and refactoring
Solver refactoring
Solver documentation
|
Here are my thoughts on improving the solver. Please let me know if you have comments or questions @martinjrobins and others. Solver optionsInitializationTime steppingIn PyBaMM, the solver currently stops at all values in the
These three reasons for setting a
If we compare the solver stats,
Even though we solve the same system, the dense
|
yea, agree that it would be great to get rid of |
If we can access IDA's internal time steps via Casadi, I think we can do most of this stuff |
Corollary from the PyBaMM developer meeting on 05/08/2024 as a part of PyBaMM running in WASM:
|
@agriyakhetarpal: FYI, I've compiled IDA with KLU using enscripten in the past, see this repo: https://github.com/martinjrobins/diffeq-runtime. However I agree that focusing on the casadi solver for now is the best approach since you have it already compiled and in Pyodide |
Thanks for the resource, @martinjrobins! I see you've built a static lib for KLU and also used |
To improve the speed of our ODE models, I'd like to add
And just FYI, I don't plan on starting this work for at least a couple of weeks. |
I'd like to continue making pybamm easier to work with for the parameter inference libraries like PyBOP (https://github.com/pybop-team/PyBOP). At the moment I think this includes:
Originally posted by @martinjrobins in #3839 (comment)
The text was updated successfully, but these errors were encountered: