Strip out code that depends on PyProto_API when exporting from Google codebase to GitHub.
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/644613416
branch
3 times, most recently
from
38b7df6
to
dbe3f58
Compare
copybara-service
bot
changed the title
PyProto_API.PyProto_API when exporting from Google codebase to GitHub.
|
@StefanBruens What I have at the moment passes project-level testing Google-internally, and GitHub testing here. I still have to run Google-internal global testing. That'll take 12+ hours probably. Then I need to get the changes reviewed internally. If you get a chance to test this PR for your purposes in the meantime, that would be great. Note that I did not adopt the CMakeLists.txt |
copybara-service
bot
force-pushed
the
cl/644613416
branch
3 times, most recently
from
7187683
to
d229c15
Compare
…le codebase to GitHub. For context see #161, in particular #161 (comment). Intentionally not stripping out the check_unknown_fields.h,cc sources: 1. For simplicity, and 2. so that it is more obvious externally what the corresponding code in pybind11_protobuf/tests/extension_test.py is about (stripping out the test code would lead to distracting clutter). PiperOrigin-RevId: 645462442
copybara-service
bot
force-pushed
the
cl/644613416
branch
from
d229c15
to
e90f33e
Compare
rwgk
pushed a commit
to StefanBruens/pybind11_protobuf
that referenced
this pull request
Jun 21, 2024
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip out code that depends on
PyProto_APIwhen exporting from Google codebase to GitHub.For context see #161, in particular #161 (comment).
Intentionally not stripping out the check_unknown_fields.h,cc sources:
For simplicity, and
so that it is more obvious externally what the corresponding code in
pybind11_protobuf/tests/extension_test.py is about
(stripping out the test code would lead to distracting clutter).