Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Type hints in ecm_tau_constraints.py #479

Closed
BradyPlanden opened this issue Aug 28, 2024 · 0 comments · Fixed by #480
Closed

[Bug]: Type hints in ecm_tau_constraints.py #479

BradyPlanden opened this issue Aug 28, 2024 · 0 comments · Fixed by #480
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.9

Describe the bug

Union type syntax of | is available in only in 3.10 onwards. As such, these lines:

PyBOP/examples/scripts/ecm_tau_constraints.py

Line 60 in cd07b14

tau_mins: float | list[float],

Need to be update to the Union syntax, i.e. tau_mins: Union[float, list[float]]

Steps to reproduce the behaviour

https://github.com/pybop-team/PyBOP/actions/runs/10593835366/job/29356214940

Relevant log output

No response
@BradyPlanden BradyPlanden added the bug Something isn't working label Aug 28, 2024
@BradyPlanden BradyPlanden mentioned this issue Aug 30, 2024
Merged
15 tasks
@BradyPlanden BradyPlanden linked a pull request Aug 30, 2024 that will close this issue
Updates type hints in ecm_tau_constraints.py #480
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates type hints in ecm_tau_constraints.py pybop-team/PyBOP
1 participant
@BradyPlanden