Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Class Properties for CLV _logp Methods #1033

Open
ColtAllen opened this issue Sep 13, 2024 · 1 comment
Open

Create Class Properties for CLV _logp Methods #1033

ColtAllen opened this issue Sep 13, 2024 · 1 comment
Labels

Comments

@ColtAllen
Copy link
Collaborator

ParetoNBDModel and BetaGeoBetaBinomModel use their respective logp functions for some of the predictive methods. Right nowlogp is being compiled every time a predictive method is called, which is inefficient. Caching this a class property would be an easy way to speed up predictions for these models.

@ColtAllen ColtAllen added enhancement New feature or request CLV priority: low labels Sep 13, 2024
@Ishaanjolly
Copy link
Contributor

Any suggestions on how to do this? It does not seem basic to just add @cached_property decorator on a @static_class function...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants