-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move transaction handling into framer socket. #2254
Comments
Correction the server still needs to know the transaction id, but since the server handles the requests one by one. the socket framer can keep the tid from the request and automatically add it to the response. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Transactions at device level is only supported by the socket framer, therefore it is logical to remove the general transaction handling, and make a specific transaction handling directly in the framer.
Seen from the APP POW, the library offers a request/response API, meaning there are never more than 1 transaction outstanding, so need for a app level transaction handling.
The request/response API is partly not protected by a lock, making it difficult for multitask application to secure serialization.
This should only be implemented in the new framers, and the old_framers kept unchanged.
The text was updated successfully, but these errors were encountered: