Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker image and push to GHCR #230

Open
wants to merge 21 commits into
base: unstable/v1
Choose a base branch
from

Commits on Sep 7, 2024

  1. Build Docker image and push to GHCR

    Up to this point, the project has been set up as a Docker action
    referencing the Dockerfile. The downside to using the Dockerfile for the
    action is that the Docker image must be built every time the action is
    used.
    
    This commit will set up the project to build the Docker image and push
    it to GitHub Container Registry (GHCR). This change will speed up user
    workflows every time the action is used because the workflows will
    simply pull the Docker image from GHCR instead of building again.
    
    Changes:
    
    - Add required metadata to Dockerfile
    - Build container image with GitHub Actions
    - Push container image to GHCR
    
    Docker actions support pulling in pre-built Docker images. The downside
    is that there's no way to specify the correct Docker tag because the
    GitHub Actions `image` and `uses:` keys don't accept any context.
    For example, if a user's workflow has
    `uses: pypa/gh-action-pypi-publish@release/v1.8`, then the action should
    pull in a Docker image built from the `release/v1.8` branch, something
    like `ghcr.io/pypa/gh-action-pypi-publish:release-v1.8` (Docker tags
    can't have `/`). The workaround is to switch the top-level `action.yml`
    to a composite action that then calls the Docker action, substituting
    the correct image name and tag.
    br3ndonland committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    eb50ad4 View commit details
    Browse the repository at this point in the history
  2. Fix pre-commit errors

    br3ndonland committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    1e0ccc9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6364a07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a6e3290 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e236daa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b17295d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9337018 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    59e3edf View commit details
    Browse the repository at this point in the history
  9. Reset smoke test path

    br3ndonland committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    90ff142 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    61e875d View commit details
    Browse the repository at this point in the history
  11. Dump action as JSON

    br3ndonland committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    c962c33 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1bcf9d8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    80b172c View commit details
    Browse the repository at this point in the history
  14. Fail-fast in unsupported environments

    pypa#230 (comment)
    
    Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
    br3ndonland and webknjaz committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    6eb8d30 View commit details
    Browse the repository at this point in the history
  15. Drop args from create-docker-action.py

    Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
    br3ndonland and webknjaz committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    8d071a8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1ce7f9d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    5521a4f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    031df10 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Configuration menu
    Copy the full SHA
    314a411 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Make smoke test job depend on build job

    pypa#230 (comment)
    
    Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
    br3ndonland and webknjaz committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    fa8a0e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    580d9d0 View commit details
    Browse the repository at this point in the history