Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip integration: figure out feature gating in pip-audit #336

Open
woodruffw opened this issue Jul 26, 2022 · 1 comment
Open

pip integration: figure out feature gating in pip-audit #336

woodruffw opened this issue Jul 26, 2022 · 1 comment

Comments

@woodruffw
Copy link
Member

Breakout from #335: we need to design an ergonomic "feature gate" scheme for pip-audit, to handle the following deployments:

  • python -m pip install pip-audit (and all third-party packages): support for SBOM generation, the OSV vulnerability service, etc.
  • pip audit: no support for -s osv, --format=spdx-..., etc.

Some ideas:

  • If "default" extras were possible, we could define osv and spdx extras that pip install would activate by default. Unfortunately, default extras are currently not possible.
  • We could probably get away with a single feature flag, something like pip_audit.VENDORED_INTO_PIP, which we then just use to remove a handful of CLI options and prevent importing pip_audit._format.cyclonedx.
@di
Copy link
Sponsor Member

di commented Jul 26, 2022

In di/pip-api#138 I made a pip_api.VENDORED flag, I would imagine we would do something similar here and could gate functionality on that. I'm not sure it needs to be specific to who has vendored us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants