Support PEP 610 editables in pip freeze and pip list #10249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2021
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
3 times, most recently
from
aae16c7
to
99f7a3b
Compare
13 tasks
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
99f7a3b
to
f095f9c
Compare
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
e2c9f41
to
73bbc05
Compare
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
73bbc05
to
391c029
Compare
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
2 times, most recently
from
e3abddd
to
6e21d74
Compare
|
I added a couple of tests. This is now ready for review. I recommend looking at individual commits separately. |
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
6e21d74
to
43ead14
Compare
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
2 times, most recently
from
1ef2aaf
to
5495f14
Compare
|
Rebased and blackened. I also added some documentation. |
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
5495f14
to
6b06b21
Compare
|
Thank for the review, @uranusjr. I handled your comments. |
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
4c8f529
to
699b432
Compare
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
699b432
to
4c82baf
Compare
uranusjr
reviewed
Aug 30, 2021
uranusjr
approved these changes
Sep 4, 2021
Make them work without using pkg_resource.
Look for the editable flag in direct_url.json, and fall back to the .egg-link search if there is no direct_url.json.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
I have tried to remove the .egg-link (in which case the package is not considered editable), and removing the package while leaving the .egg-link (in which case the package is not shown). I could not produce this "Editable install not found" message with pip 21.2. So I think this is dead code and I'm replacing this test by an assert.
sbidoul
force-pushed
the
list-freeze-pep610-sbi
branch
from
7bf6b89
to
ca05176
Compare
1 task
|
Rebased and still green. So I'm going ahead and merging this. Thanks for the review @uranusjr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes pip list and freeze support PEP 610 editables (from direct_url.json), in preparation for PEP 660.
This should be fully backward compatible. The new column in pip list column format is not a breaking change because it is meant for human consumption (the json format is there for machines, and in the semantics of existing field did not change in the json output).
direct_url.json, fallback on the legacy.egg-linksearch.Editable project locationcolumn in pip list default output. This column appears only when there is and editable project in the list. TheLocationcolumn appears in verbose mode only and shows the same value as before (i.e. the parent of the metadata directory). Closes New pip list column: Editable project location #10245.editable_project_locationfield to pip list json output (closes pip list in JSON format does not contain location for editable installs #7664, supersedes Include editable locations in JSON output of list #7670).editable_project_locationin pip freeze.get_installed_distributionsfunction.This may be tested by installing a flit project with
flit install --pthorflit install --symlinkand noticing that pip list and pip freeze correctly detect it as editable.