Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate installing packages w/o install-record.txt #7702

Closed
wants to merge 1 commit into from
Closed

Deprecate installing packages w/o install-record.txt #7702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/pip/_internal/operations/install/legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,16 @@ def install(
)

if not os.path.exists(record_filename):
logger.debug('Record file %s not found', record_filename)
logger.warning('Record file %s not found', record_filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention the name of the package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The record filename should include that. :P

You're right -- explicitly mentioning the pacakge name will more directly surface relevant info to the user. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something it's just in a temporary directory with a generic name.

deprecated(
chrahunt marked this conversation as resolved.
Show resolved Hide resolved
reason=(
"Package did not generate an install-record.txt, which "
"would render it not-uninstallable."
),
gone_in="20.3",
replacement=None,
issue=7450,
)
return
install_req.install_succeeded = True

Expand Down