From 5df52826ee7b6bcc2ef310c7089b0c37975b3732 Mon Sep 17 00:00:00 2001 From: Dan Ryan Date: Sun, 17 May 2020 01:12:23 -0400 Subject: [PATCH] Fix resolution of direct url subdependencies - Fix resolution of direct url VCS subdependencies (e.g. top level dep depends on a VCS direct url subdependency) which rely on subdirectory resolution - Fixes #3976 Signed-off-by: Dan Ryan --- news/3976.bugfix.rst | 1 + pipenv/utils.py | 2 ++ 2 files changed, 3 insertions(+) create mode 100644 news/3976.bugfix.rst diff --git a/news/3976.bugfix.rst b/news/3976.bugfix.rst new file mode 100644 index 0000000000..4dd381df35 --- /dev/null +++ b/news/3976.bugfix.rst @@ -0,0 +1 @@ +Fixed a bug which prevented resolution of direct URL dependencies which have PEP508 style direct url VCS sub-dependencies with subdirectories. diff --git a/pipenv/utils.py b/pipenv/utils.py index ed8ed29661..8718556457 100644 --- a/pipenv/utils.py +++ b/pipenv/utils.py @@ -997,6 +997,8 @@ def clean_results(self): for req, ireq in reqs: if (req.vcs and req.editable and not req.is_direct_url): continue + elif req.normalized_name in self.skipped.keys(): + continue collected_hashes = self.collect_hashes(ireq) req = req.add_hashes(collected_hashes) if not collected_hashes and self._should_include_hash(ireq):