Inject '' into sys.path in PEP 517 implementation #1643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maintains backward compatibility to non-isolated build semantics, where it is common to import the module in setup.py.
uranusjr
force-pushed
the
pep-517-inject-sys-path
branch
from
a5ca4cd
to
9c86e0e
Compare
|
I don’t understand what’s wrong here, is pip failing to install setuptools in Python 2? |
I don't either, but I'm tracking it in #1644. |
pganssle
added a commit
to pganssle/setuptools
that referenced
this pull request
Jan 27, 2019
Failing test adapted from PR pypa#1643 Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
2 tasks
pganssle
added a commit
to pganssle/setuptools
that referenced
this pull request
Jan 27, 2019
Failing test adapted from PR pypa#1643 Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
|
Closing in favour of #1652. |
pganssle
added a commit
to pganssle/setuptools
that referenced
this pull request
Jan 31, 2019
Failing test adapted from PR pypa#1643 Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
pganssle
added a commit
to pganssle/setuptools
that referenced
this pull request
Feb 3, 2019
Failing test adapted from PR pypa#1643 Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Injects
''(current working directory) intosys.pathif needed when running setup.py in the PEP 517 backend.Closes #1642.
Pull Request Checklist