-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize test_manifest
to use new log infra
#3701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
changed the title
Modernize test_manifest to use new log infra
Modernize Nov 22, 2022
test_manifest
to use new log infra
For some reason the CI is not kicking in... |
abravalheri
force-pushed
the
update-test-manifest
branch
from
November 22, 2022 16:37
9df6af9
to
6b53b05
Compare
abravalheri
force-pushed
the
update-test-manifest
branch
from
November 22, 2022 18:37
bc5ad8a
to
01599c5
Compare
I tried to replicate locally the failing CI job with `PyPy 7.3.9 with GCC 10.2.1 20210130 (Red Hat 10.2.1-11)`, without success.$ tox -e pypy3 -- -p no:cov -p no:perf setuptools/tests/test_manifest.py
pypy3 develop-inst-noop: /home/abravalheri/workspace/setuptools
pypy3 installed: attrs==22.1.0,autocommand==2.2.2,build==0.9.0,cffi==1.15.0,distlib==0.3.6,docutils==0.19,exceptiongroup==1.0.4,execnet==1.9.0,filelock==3.8.0,flake8==4.0.1,flake8-2020==1.6.1,greenlet==0.4.13,hpy==0.0.3,importlib-metadata==5.0.0,ini2toml==0.11.1,iniconfig==1.1.1,jaraco.context==4.2.0,jaraco.envs==2.4.0,jaraco.functools==3.5.2,jaraco.path==3.4.0,mccabe==0.6.1,more-itertools==9.0.0,packaging==21.3,path==16.5.0,pep517==0.13.0,pip-run==8.8.2,platformdirs==2.5.4,pluggy==1.0.0,py==1.11.0,pycodestyle==2.8.0,pyflakes==2.4.0,pyparsing==3.0.9,pytest==7.2.0,pytest-checkdocs==2.9.0,pytest-enabler==1.3.0,pytest-flake8==1.1.1,pytest-perf==0.12.1,pytest-timeout==2.1.0,pytest-xdist==3.0.2,pytz==2022.6,readline==6.2.4.1,six==1.16.0,tempora==5.1.0,toml==0.10.2,tomli==2.0.1,tomli_w==1.0.0,tox==3.27.1,virtualenv==20.16.7,zipp==3.10.0
pypy3 run-test-pre: PYTHONHASHSEED='147068396'
pypy3 run-test: commands[0] | pytest -p no:cov -p no:perf setuptools/tests/test_manifest.py
# ...
.................................................................... [100%]
========================================== 68 passed in 9.62s ==========================================
_______________________________________________ summary ________________________________________________
pypy3: commands succeeded
congratulations :) I also tried to create a small standalone test for PyPy and caplog, but things seem to work fine...rm -rf /tmp/test-caplog-pypy
mkdir /tmp/test-caplog-pypy
cd /tmp/test-caplog-pypy
pypy3.9 -m venv .venv
.venv/bin/python -m pip install -U pip pytest
cat <<EOF > test_caplog.py
import logging
import pytest
def test_caplog(caplog):
caplog.set_level(logging.DEBUG)
logging.warning("hello world")
print(caplog.records)
assert len(caplog.records) > 0
EOF
.venv/bin/pytest test_caplog.py I wonder if there is something particular about the way GHA sets up pypy3... Meanwhile I added an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some tests in test_manifest only run for
SETUPTOOLS_USE_DISTUTILS=stdlib
because they rely on the old logging infrastructure.In pypa/distutils#192 I also noticed that if
distutils.log.Log
is reinstated for backward compatibility, these tests will fail.Summary of changes
Closes
Pull Request Checklist
changelog.d/
.(See documentation for details)