Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register_assert_rewrite warns for already imported and rewritten modules #1840

Closed
RonnyPfannschmidt opened this issue Aug 22, 2016 · 4 comments
Closed

register_assert_rewrite warns for already imported and rewritten modules #1840

RonnyPfannschmidt opened this issue Aug 22, 2016 · 4 comments
Assignees
@RonnyPfannschmidt
Labels
type: bug problem that needs to be addressed

Comments

@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Aug 22, 2016 •
edited
Loading

edited

it appears some code is reloading conftest which in turn runs a register once before and once after import
@RonnyPfannschmidt RonnyPfannschmidt changed the title register_assert_rewrite doesn't work in conftest register_assert_rewrite warns for already imported and rewritten modules Aug 22, 2016
@RonnyPfannschmidt RonnyPfannschmidt added the type: bug problem that needs to be addressed label Aug 22, 2016
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Aug 22, 2016
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Aug 22, 2016
Closed
@nicoddemus
Copy link
Member

@RonnyPfannschmidt any more information on this? I ask because I would like to release 3.0.1 soon (like tomorrow) if possible. 😁

@RonnyPfannschmidt
Copy link
Member Author

Im still investigating

@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Oct 17, 2016
Closed
@RonnyPfannschmidt
Copy link
Member Author

close in favour of #2005

@nicoddemus
Copy link
Member

👍

@pytestbot pytestbot mentioned this issue May 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

Labels
type: bug problem that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RonnyPfannschmidt @nicoddemus