Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long filenames break the alignment of progress information #3374

Open
InDevRus opened this issue Apr 6, 2018 · 4 comments
Open

Long filenames break the alignment of progress information #3374

InDevRus opened this issue Apr 6, 2018 · 4 comments
Assignees
Labels
topic: reporting related to terminal output and user-facing messages and errors type: enhancement new feature or API change, should be merged into features branch

Comments

@InDevRus
Copy link

InDevRus commented Apr 6, 2018

After pytest launch I got this:

> pytest
============================= test session starts =============================
platform win32 -- Python 3.6.5, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: C:\Users\InDev\OneDrive\Education\Языки сценариев\polynomials, inifile:
collected 44 items

tests\test_error_checker\test_parentheses_checker.py ..........          [ 22%]
tests\test_error_checker\test_unexpected_symbol_checker.py ..........    [ 45%]
tests\test_general\test_find_parentheses.py ........                     [ 63%]
tests\test_general\test_find_surface_operators.py .....                  [ 75%]
tests\test_general\test_find_last_operator\test_correct_expressions.py . [ 77%]
.......                                                                  [ 93%]
tests\test_general\test_find_last_operator\test_incorrect_expressions.py . [ 95%]
                                                                         [ 95%]
tests\test_general\test_find_last_operator\test_monomials.py ..          [100%]

========================== 44 passed in 0.33 seconds ==========================

Some lines here ignored indentation.

> pip freeze
attrs==17.4.0
backcall==0.1.0
colorama==0.3.9
cymruwhois==1.6
decorator==4.2.1
dnspython==1.15.0
future==0.16.0
ipython==6.3.0
ipython-genutils==0.2.0
jedi==0.11.1
more-itertools==4.1.0
parso==0.1.1
pickleshare==0.7.4
pluggy==0.6.0
prompt-toolkit==1.0.15
py==1.5.3
Pygments==2.2.0
pytest==3.5.0
pythonwhois==2.4.3
simplegeneric==0.8.1
six==1.11.0
traitlets==4.3.2
wcwidth==0.1.7
@pytestbot pytestbot added the type: question general question, might be closed after 2 weeks of inactivity label Apr 6, 2018
@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #2172 (Capturing output causes test to fail.), #1067 (Broken link), #1792 (Proposal: Verbose output from tests through decorators.), #1044 (from mock import call breaks test collector), and #153 (test intents).

@pytestbot pytestbot added plugin: pytester related to the pytester builtin plugin type: bug problem that needs to be addressed labels Apr 6, 2018
@nicoddemus nicoddemus added status: needs information reporter needs to provide more information; can be closed after 2 or more weeks of inactivity and removed plugin: pytester related to the pytester builtin plugin type: bug problem that needs to be addressed labels Apr 9, 2018
@nicoddemus
Copy link
Member

@InDevRus I didn't quite get what the problem is; if you mean this line:

tests\test_general\test_find_last_operator\test_incorrect_expressions.py . [ 95%]

That's because it is too long so we have no choice but print the progress information after it.

Btw you can set the COLUMNS environment variable to allow for wider output (say COLUMNS=120).

@RonnyPfannschmidt
Copy link
Member

@nicoddemus i believe we should spill the dots into the next line earlier and simply have a line of only the filename displayed

@nicoddemus
Copy link
Member

There might be the case where the filename is just too large to show under the current terminal width, in that case I agree showing only the filename and any other dots + progress information starting in the next line. 👍

@nicoddemus nicoddemus changed the title Broken test launch output in PowerShell. Long filenames break the alignment of progress information Apr 10, 2018
@nicoddemus nicoddemus added type: enhancement new feature or API change, should be merged into features branch topic: reporting related to terminal output and user-facing messages and errors and removed status: needs information reporter needs to provide more information; can be closed after 2 or more weeks of inactivity type: question general question, might be closed after 2 weeks of inactivity labels Apr 10, 2018
@feuillemorte feuillemorte self-assigned this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: reporting related to terminal output and user-facing messages and errors type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Development

No branches or pull requests

5 participants