Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs about junit_family warning message #7153

Merged
merged 1 commit into from
May 2, 2020

Conversation

nicoddemus
Copy link
Member

From discussion in #6178

cc @bittner

@nicoddemus nicoddemus requested a review from jaraco May 2, 2020 12:58
Copy link

@bittner bittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicoddemus
Copy link
Member Author

@bittner thanks for the review!

@jaraco
Copy link
Contributor

jaraco commented May 2, 2020

This looks good to me. Perhaps the docs should keep a list of environments that are known to work with the new format rather than to ask each user to perform the experiment. I’ve already validated Azure Pipelines.

@nicoddemus
Copy link
Member Author

Perhaps the docs should keep a list of environments that are known to work with the new format

I will add Jenkins and Azure then, then users are welcome to contribute to update the list.

@nicoddemus nicoddemus merged commit 2b51ed4 into pytest-dev:master May 2, 2020
@nicoddemus nicoddemus deleted the xunit-warning-update branch May 2, 2020 16:31
@nicoddemus
Copy link
Member Author

Thanks @jaraco and @bittner for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants