Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional dependency version for autopep8 #514

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

doolio
Copy link
Contributor

@doolio doolio commented Jan 19, 2024

This ensures the same version of autopep8 is installed whether the user passes "python-lsp-server[all]" or "python-lsp-server[autopep8]" to pip.

Fixes #513

This ensures the same version of autopep8 is installed whether the user
passes "python-lsp-server[all]" or "python-lsp-server[autopep8]" to pip.

Resolves: python-lsp#513
@doolio
Copy link
Contributor Author

doolio commented Jan 19, 2024

I assumed the version installed by [all] is the desired version as I presume most users install with that option.

@ccordoba12 ccordoba12 added this to the v1.10.0 milestone Jan 19, 2024
@ccordoba12 ccordoba12 changed the title Fix optional dependency version Fix optional dependency version for autopep8 Jan 19, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @doolio!

@ccordoba12 ccordoba12 merged commit cb213e0 into python-lsp:develop Jan 19, 2024
10 checks passed
@doolio doolio deleted the fix-dependency-autopep8-version branch January 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different versions of autopep can be installed as optional dependencies
2 participants