Fix progress reporting with autoimport plugin #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is temporary fix, until someone can make proper fix by resolving issue with thread, seems like it just hungs indefinitely instead of reporting progress. Also, this thread does not exit properly, and pylsp does not exit after editor is closed. Refs python-lsp#374
|
@tkrabel i'm tagging you, maybe you have better idea how to fix this. Was it working when you tested it? Right now seems like thread just hangs indefinitely and not exit. |
|
@last-partizan thanks for the git bisect and for tagging me. I did a unit an manual test to make sure everything worked, but I might have missed something. Making the progress report single threaded seems to be a good tactical fix. I will investigate how I can solve the issue without losing the non-blocking feature. |
|
@tkrabel, are you ok with merging this one and release 1.10.1 while you try to find a better solution? |
ccordoba12
changed the title
|
@ccordoba12 yes that LGTM |
|
Was able to test this PR locally and confirmed that the issue present in #529 stopped occurring 🙌 |
ccordoba12
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporary fix, until someone can make proper fix by resolving issue with thread, seems like it just hungs indefinitely instead of reporting progress.
Also, this thread does not exit properly, and pylsp does not exit after editor is closed.
Fixes #529.
Refs #374