-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry does not add all hashes for multiple constraint dependences #6349
Comments
As a work-around, it seems manually editing |
poetry has never stored hashes for url dependencies, and I don't think this is a regression. poetry goes "if I have any hashes for this package, then this file had better match one of them". But since it only stored hashes for the non-url package (which has always been the case), that fails. I haven't tried to reproduce so may be misreading: but so far as I can see this code was much the same at earlier releases, here's 1.1.15 poetry/poetry/installation/executor.py Line 616 in 46bf7fd
|
I didn't claim Poetry stored hashes for url dependencies in ealier versions. The issue is: why does it expect to find a hash for this particular url dependency if it doesn't store them? |
I don't know how to answer your question without just saying what I already said so here goes:
|
Actually, just another effect of the same bug as #6327. Thus, same fix. As already mentioned the missing hashes are not a regression, but the failing installation is a regression. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).Issue
The same example as in #6327. If package to be installed depends on the OS:
Running
poetry lock
on Linux only adds hashes for the Linux version of the package. poetry.lock only contains:And this is despite the fact that on Linux,
poetry lock
every time re-downloads the Windows package again.Using this lockfile,
poetry install
on Windows causes the following error (note, this has different version numbers, I don't have Windows myself to reproduce cleanly)I believe this is a regression in Poetry 1.2.0. It seems 1.1.14 simply ignored the missing hash on Windows, but 1.2 is stricter and fails because of it.
The text was updated successfully, but these errors were encountered: