-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New check: Use of deprecated feature (?) #134
Comments
This code suggests that the only other one is that I think we should deprecated passing |
Should we lint on |
Also, I'll let you press the assign button if you approve of adding it. Might wait with it until after libcst, even though it is going to be a very simple check. |
In principle probably yes; in practice we monkeypatch it on so let's not 😜 |
lmao. Still might be a useful check for other users of the plugin though - and I imagine a lot wouldn't even be aware of the flag until warned. |
Hmm, still inclined against. There are trade-offs which mean you might not want to yet, and it'll be the default behaviour at some point anyway. |
Well, it's generally a good idea to stay ahead of future default behaviour changes, and in this case (once you're on 3.11) it seems like a clear upside. But makes sense to delay it until later, making it optional would probably not achieve much. One could make it non-optional with a good message and just expect users to disable the check if they want to stay on old behaviour for now, it's at least not going to be a noisy check since I'm guessing most programs only have a few calls to |
The ecosystem needs a bit longer to catch up IMO; there are still quite a few libraries which don't actually handle |
Trio is good at raising |
Split out from #121
New error: use of deprecated [function/method/etc], or can reuse TRIO117 now that there's a decent way of having multiple messages for the same error.
Are there any other trio deprecated funcs than multierror?
non-explicit strict_exception_groups=True? (Or maybe that's a separate check for excepts without groups)
The text was updated successfully, but these errors were encountered: