-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python_requires to >= 3.6 #98
Conversation
Trio >= 0.15.0 is required and that in turn requires Python >= 3.6
Oh, and now CI is broken because of pytest changes (I guess). Fantastic... |
Too bad we don't have dependabot on this repo, would have caught it much earlier when pytest made the release that broke things... |
Yeah, I was pulling up master to explore. |
And yup, it comes back to me anyways... based on issues in pytest-dev/pytest#6505
Side note, since we don't pin the deps wouldn't just a nightly build would cut it for catching stuff like this instead of needing dependabot? |
It could, but pinning + dependabot is better, because when something goes wrong then you end up with a failed PR that you can investigate and resolve at your leisure. Without pinning, things just catch on fire and you find out after the fact when they're already burning. (Also, I'm not sure how you'd set up useful alerting for nightly builds.) |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 18 18
Lines 490 490
Branches 41 41
=======================================
Hits 489 489
Misses 1 1 |
Oh sure, as far as alerting I just get an email... as the owner? I don't know. I just meant from the point of not having pinning. And pinning is hard what with no tooling for handling multiple platforms. At least I'm not familiar with anything yet other than my boots/romp combo but... meh. |
Pinning tools do have lousy support for multiple platforms, but we don't
have a lot of platform-specific dependencies, so we've managed to get away
with it so far.
…On Sat, Aug 22, 2020 at 4:47 PM Kyle Altendorf ***@***.***> wrote:
Oh sure, as far as alerting I just get an email... as the owner? I don't
know. I just meant from the point of not having pinning. And pinning is
hard what with no tooling for handling multiple platforms. At least I'm not
familiar with anything yet other than my boots/romp combo but... meh.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEU42A2DHTTNCOMFCG5XKDSCBKHLANCNFSM4QIJHXAA>
.
--
Nathaniel J. Smith -- https://vorpus.org <http://vorpus.org>
|
Trio >= 0.15.0 is required and that in turn requires Python >= 3.6
https://github.com/python-trio/pytest-trio/blob/cb90c329a621e57e1243c2747fe6406866f0d80b/setup.py
https://github.com/python-trio/trio/blob/v0.15.0/setup.py#L97