Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace call to add_stylesheet with add_css_file #277

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

befeleme
Copy link
Contributor

This should fix documentation build failures with Sphinx 4.

This should prevent documentation build failures with Sphinx 4.
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #277 (835bb2b) into master (867c4af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           3        3           
  Lines         273      273           
  Branches       46       46           
=======================================
  Hits          270      270           
  Partials        3        3           

@njsmith
Copy link
Member

njsmith commented Jun 16, 2021

Ugh thank you, tacking down sphinx regressions is the worst.

@njsmith njsmith merged commit 928573f into python-trio:master Jun 16, 2021
@trio-bot
Copy link

trio-bot bot commented Jun 16, 2021

Hey @befeleme, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@pquentin
Copy link
Member

@befeleme Thank you! Would you happen to be interested in opening a pull request that tests Sphinx 4? The CI is still only testing Sphinx 3 and earlier

https://github.com/python-trio/sphinxcontrib-trio/blob/master/.github/workflows/ci.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants