Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getaddrinfo pluggable #159

Closed
njsmith opened this issue May 16, 2017 · 1 comment
Closed

Make getaddrinfo pluggable #159

njsmith opened this issue May 16, 2017 · 1 comment

Comments

@njsmith
Copy link
Member

njsmith commented May 16, 2017

APIs that perform name lookups should take an argument (defaulting to trio.socket.getaddrinfo) specifying the function to use for looking up names. This is useful for testing, and it's useful for folks who might want to use some other name lookup code (e.g. an async dns library like pycares).

@njsmith
Copy link
Member Author

njsmith commented Aug 8, 2017

The getaddrinfo hook added in #253 provides this (though in a different way than suggested above).

@njsmith njsmith closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant