Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Replace codecov uploader with a modern version in GHA #2650

Closed
webknjaz opened this issue May 25, 2023 · 0 comments · Fixed by #2653
Closed

[TODO] Replace codecov uploader with a modern version in GHA #2650

webknjaz opened this issue May 25, 2023 · 0 comments · Fixed by #2653

Comments

@webknjaz
Copy link
Member

Currently, codecov is called from ci.sh but it uses a long-deprecated version of the uploader. Codecov deprecated their “legacy” uploaders after the breach in 2020 and have since migrated to a unified one. They also have an official GitHub Action that makes use of it. Several months ago, they've started actively deleting the uploading capabilities (and removed the PyPI package, for example).

I think, having custom logic in a shell script brings more maintenance burden than having it in the CI definition directly. Let's move towards GHA, especially since it's not really necessary to make uploads from the local runs outside the CI...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant