SocketListener ignores peer address

[adontz]

Currently SocketListener ignores peer address returned socket.accept

trio/trio/_highlevel_socket.py

Line 371 in b208624

sock, _ = await self.socket.accept()

What is rationale behind this and what can be done to receive this information?

[njsmith]

You can always get the peer address from the socket object itself by calling sock.getpeername().

Currently the "high level" Stream interface doesn't have a "high level" wrapper for this – fixing that is issue #280.

But, SocketStream's do expose the Trio socket object, so you can just call getpeername on that. Example:

import trio

async def server(stream):
    print("Got connection from:", stream.socket.getpeername())

trio.run(trio.serve_tcp, server, 12345)

And then if I do nc localhost 12345, the program prints something like:

Got connection from: ('127.0.0.1', 54888)

I don't think there's any further todo item for trio here, so marking this closed, but feel free to continue discussion or reopen if you want.

[njsmith]

Oh, and if you're using serve_ssl_over_tcp, then the magic incantation is: stream.transport_stream.socket.getpeername()

[pquentin]

I think @njsmith forgot to hit on the close button, so doing that now. Again, feel free to reopen!

[njsmith]

Whoops, thanks for the catch :-)