Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the distinction between wait_readable / wait_socket_readable #878

Closed
njsmith opened this issue Jan 25, 2019 · 0 comments · Fixed by #1119
Closed

Drop the distinction between wait_readable / wait_socket_readable #878

njsmith opened this issue Jan 25, 2019 · 0 comments · Fixed by #1119
Labels
low-level potential API breaker todo soon

Comments

@njsmith
Copy link
Member

njsmith commented Jan 25, 2019

As discussed in #400, and specifically this comment, we should drop the distinction between wait_readable and wait_socket_readable (and similar for writable, notify_close). Instead, we should just document that on Unix they take file descriptors, and on Windows they take socket handles (not file descriptors).

(Should they also accept other handles? See also: #661 (comment))
njsmith added a commit to njsmith/trio that referenced this issue Jun 20, 2019
@njsmith
Standardize the names of wait_* and notify_closing across platforms
78027f9 
Fixes python-triogh-878
@njsmith njsmith mentioned this issue Jun 20, 2019
Merged
njsmith added a commit to python-trio/snekomatic that referenced this issue Aug 17, 2019
@njsmith
Disable -W error for now
35ba06d 
We're hitting two sets of warnings in third-party code. And for some
reason, I *cannot* figure out how to filter them out right now...

tests/test_gh.py::test_basic_gh_client
tests/test_gh.py::test_client_part_of_app
  /home/njs/.user-python3.7/lib/python3.7/site-packages/anyio/_backends/_trio.py:199: TrioDeprecationWarning: trio.hazmat.wait_socket_writable is deprecated since Trio 0.12.0; use trio.hazmat.wait_writable instead (python-trio/trio#878)
    await trio.hazmat.wait_socket_writable(sock)

tests/test_gh.py::test_basic_gh_client
tests/test_gh.py::test_client_part_of_app
  /home/njs/.user-python3.7/lib/python3.7/site-packages/anyio/_backends/_trio.py:190: TrioDeprecationWarning: trio.hazmat.wait_socket_readable is deprecated since Trio 0.12.0; use trio.hazmat.wait_readable instead (python-trio/trio#878)
    await trio.hazmat.wait_socket_readable(sock)

tests/test_gh.py::test_basic_gh_client
tests/test_gh.py::test_client_part_of_app
  /home/njs/.user-python3.7/lib/python3.7/site-packages/anyio/_backends/_trio.py:179: TrioDeprecationWarning: trio.hazmat.notify_socket_close is deprecated since Trio 0.12.0; use trio.hazmat.notify_closing instead (python-trio/trio#878)
    trio.hazmat.notify_socket_close(self._raw_socket)

tests/test_gh.py::test_client_part_of_app
  /home/njs/.user-python3.7/lib/python3.7/site-packages/uritemplate/variable.py:363: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    return isinstance(value, (dict, collections.MutableMapping))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-level potential API breaker todo soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize the names of wait_* and notify_closing across platforms njsmith/trio
2 participants
@njsmith @oremanj