Fix attrs redone

[A5rocks]

#3054 didn't catch everything. However the root cause was that pytest imports trio during plugin phase and doesn't handle deprecation warnings by erroring then.

To fix that, we can just clear the module cache and try importing again. I'm not completely sold on this idea but it's the best one I had and it works.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (223e4f4) to head (72c1c68).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3058   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         120      121    +1     
  Lines       17832    17839    +7     
  Branches     3204     3206    +2     
=======================================
+ Hits        17767    17774    +7     
  Misses         46       46           
  Partials       19       19           

Files	Coverage Δ
src/trio/_tests/test_trio.py	100.00% <100.00%> (ø)
src/trio/_tests/tools/test_mypy_annotate.py	100.00% <100.00%> (ø)
src/trio/_threads.py	100.00% <100.00%> (ø)

[CoolCat467]

Looks good, but to be honest kind of confused about the reasoning for test_endtoend changes

[A5rocks]

The mypy annotate tool uses pickle so you don't want to use a cached version of trio otherwise it fails.

(It gets the cached version of trio even though that was deleted from sys.modules because it's cached by the tool)

[CoolCat467]

Makes sense, thanks for explaining. In that case though, why is there another call to cached main just a few lines down then?

trio/src/trio/_tests/tools/test_mypy_annotate.py

Line 131 in 72c1c68

main(["--dumpfile", str(result_file)])

[A5rocks]

Oh I missed that! I'm surprised that doesn't error.

I assume it's cause it loads the object from pickle which uses the version of trio I just used rather than the one cached in the main. That's just a guess though.

[A5rocks]

Sorry about the review request, I tried something that seemed to work locally but it didn't work in CI (after I requested your review again).

I probably just somehow set things up incorrectly.