Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ip_address): properly handle private is false #374

Merged
merged 4 commits into from
May 17, 2024

Conversation

grleblanc
Copy link

@grleblanc grleblanc commented May 9, 2024

Fixes #373

  • Update the test docstrings

src/validators/ip_address.py Outdated Show resolved Hide resolved
tests/test_ip_address.py Show resolved Hide resolved
@grleblanc grleblanc requested a review from yozachar May 14, 2024 00:23
src/validators/ip_address.py Outdated Show resolved Hide resolved
tests/test_ip_address.py Outdated Show resolved Hide resolved
tests/test_ip_address.py Outdated Show resolved Hide resolved
tests/test_ip_address.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@yozachar yozachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

@yozachar yozachar merged commit bcb1342 into python-validators:master May 17, 2024
17 checks passed
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 28, 2024
https://build.opensuse.org/request/show/1176833
by user mia + anag+factory
- Update to 0.28.3
  * ensure _tld.txt is in sdist and bdist
    gh#python-validators/validators#379
- Changes in 0.28.2:
  * fix: corrects a few typo
    gh#python-validators/validators#371
  * fix(ip_address): properly handle private is false
    gh#python-validators/validators#374
  * chore(url): allow symbols and pictographs in url
    gh#python-validators/validators#375
@yozachar yozachar added the maintenance PR: Alters existing source code label Sep 13, 2024
@yozachar yozachar self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR: Alters existing source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validators.ip_address private kwarg does not work as intended
3 participants