From 484a2357c8385694a077cf2ce0517f327fb0b172 Mon Sep 17 00:00:00 2001 From: jackh-ncl <1750152+jackh-ncl@users.noreply.github.com> Date: Fri, 10 Jun 2022 23:57:04 +0100 Subject: [PATCH] gh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_zipimport.py` (GH-93236) --- Lib/test/test_zipimport.py | 5 ++++- .../next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py index 66789262dd6ca1..84995be3295682 100644 --- a/Lib/test/test_zipimport.py +++ b/Lib/test/test_zipimport.py @@ -654,7 +654,10 @@ def test(val): sys.path.insert(0, TEMP_ZIP) mod = importlib.import_module(TESTMOD) self.assertEqual(mod.test(1), 1) - self.assertRaises(AssertionError, mod.test, False) + if __debug__: + self.assertRaises(AssertionError, mod.test, False) + else: + self.assertEqual(mod.test(0), 0) def testImport_WithStuff(self): # try importing from a zipfile which contains additional diff --git a/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst b/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst new file mode 100644 index 00000000000000..93c1ffe33f28a6 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst @@ -0,0 +1 @@ +Fixing tests that fail when running with optimizations (``-O``) in ``test_zipimport.py``