From 5445e173e76ec792358082caf660fbdc846c64b2 Mon Sep 17 00:00:00 2001 From: Gregory Beauregard Date: Fri, 28 Jan 2022 08:58:39 -0800 Subject: [PATCH] bpo-46553: allow bare typing.ClassVar annotations (#30983) These are used in the wild and covered by dataclasses unit tests. Several static type checkers support this pattern. --- Lib/test/test_typing.py | 6 +++++- Lib/typing.py | 2 +- .../next/Library/2022-01-28-08-47-53.bpo-46553.f7Uc96.rst | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2022-01-28-08-47-53.bpo-46553.f7Uc96.rst diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 3069331c2a3541..8449affd03a768 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -2071,7 +2071,7 @@ def test_fail_with_bare_union(self): with self.assertRaises(TypeError): Tuple[Optional] with self.assertRaises(TypeError): - ClassVar[ClassVar] + ClassVar[ClassVar[int]] with self.assertRaises(TypeError): List[ClassVar[int]] @@ -2896,12 +2896,16 @@ def test_special_forms_forward(self): class C: a: Annotated['ClassVar[int]', (3, 5)] = 4 b: Annotated['Final[int]', "const"] = 4 + x: 'ClassVar' = 4 + y: 'Final' = 4 class CF: b: List['Final[int]'] = 4 self.assertEqual(get_type_hints(C, globals())['a'], ClassVar[int]) self.assertEqual(get_type_hints(C, globals())['b'], Final[int]) + self.assertEqual(get_type_hints(C, globals())['x'], ClassVar) + self.assertEqual(get_type_hints(C, globals())['y'], Final) with self.assertRaises(TypeError): get_type_hints(CF, globals()), diff --git a/Lib/typing.py b/Lib/typing.py index 36b95d70dea5ba..232aa1a50d2e53 100644 --- a/Lib/typing.py +++ b/Lib/typing.py @@ -173,7 +173,7 @@ def _type_check(arg, msg, is_argument=True, module=None, *, allow_special_forms= if (isinstance(arg, _GenericAlias) and arg.__origin__ in invalid_generic_forms): raise TypeError(f"{arg} is not valid as type argument") - if arg in (Any, NoReturn, Final): + if arg in (Any, NoReturn, ClassVar, Final): return arg if isinstance(arg, _SpecialForm) or arg in (Generic, Protocol): raise TypeError(f"Plain {arg} is not valid as type argument") diff --git a/Misc/NEWS.d/next/Library/2022-01-28-08-47-53.bpo-46553.f7Uc96.rst b/Misc/NEWS.d/next/Library/2022-01-28-08-47-53.bpo-46553.f7Uc96.rst new file mode 100644 index 00000000000000..2c03912afcb451 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-01-28-08-47-53.bpo-46553.f7Uc96.rst @@ -0,0 +1 @@ +In :func:`typing.get_type_hints`, support evaluating bare stringified ``ClassVar`` annotations. Patch by Gregory Beauregard.