Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wave: Deprecate getmark(), setmark() and getmarkers() methods #105096

Closed
vstinner opened this issue May 30, 2023 · 0 comments
Closed

wave: Deprecate getmark(), setmark() and getmarkers() methods #105096

vstinner opened this issue May 30, 2023 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented May 30, 2023 •
edited by bedevere-bot
Loading

The wave module has getmark(), setmark() and getmarkers() methods (in Wave_read and Wave_write classes) which only exist for compatibility with the aifc module which has been removed in Python 3.13 (PR #104933). I propose to remove these methods.

  • getmark() and setmark() always raise an exception, and getmarkers() always returns None (do nothing else): these methods are not very useful.
  • Wave_write methods, getmark(), setmark() and getmarkers(), are not documented
  • None of these methods are tested

Linked PRs
@vstinner vstinner added the type-bug An unexpected behavior, bug, or error label May 30, 2023
vstinner added a commit to vstinner/cpython that referenced this issue May 30, 2023
@vstinner
pythongh-105096: Deprecate wave getmarkers() method
8121bb2 
Deprecate the getmark(), setmark() and getmarkers() methods of the
Wave_read and Wave_write classes of the wave module.
vstinner added a commit to vstinner/cpython that referenced this issue May 30, 2023
@vstinner
pythongh-105096: Deprecate wave getmarkers() method
7f4c3e5 
wave: Deprecate the getmark(), setmark() and getmarkers() methods of
the Wave_read and Wave_write classes. They will be removed in Python
3.15.
@bedevere-bot bedevere-bot mentioned this issue May 30, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue May 30, 2023
@vstinner
pythongh-105096: Deprecate wave getmarkers() method
495a8d3 
wave: Deprecate the getmark(), setmark() and getmarkers() methods of
the Wave_read and Wave_write classes. They will be removed in Python
3.15.
@vstinner vstinner mentioned this issue May 30, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue May 31, 2023
@vstinner
pythongh-105096: Reformat wave documentation
54825f4 
Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
@bedevere-bot bedevere-bot mentioned this issue May 31, 2023
Merged
vstinner added a commit that referenced this issue May 31, 2023
@vstinner
gh-105096: Reformat wave documentation (#105136)
85e5d03 
Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore
@bedevere-bot bedevere-bot mentioned this issue May 31, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue May 31, 2023
@vstinner
pythongh-105096: Reformat wave documentation (python#105136)
f612e69 
Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
vstinner added a commit to vstinner/cpython that referenced this issue May 31, 2023
@vstinner
pythongh-105096: Deprecate wave getmarkers() method
aa6cc51 
wave: Deprecate the getmark(), setmark() and getmarkers() methods of
the Wave_read and Wave_write classes. They will be removed in Python
3.15.
vstinner added a commit that referenced this issue May 31, 2023
@vstinner
[3.12] gh-105096: Reformat wave documentation (#105136) (#105138)
01b42f9 
gh-105096: Reformat wave documentation (#105136)

Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
vstinner added a commit that referenced this issue May 31, 2023
@vstinner
gh-105096: Deprecate wave getmarkers() method (#105098)
03ad662 
wave: Deprecate the getmark(), setmark() and getmarkers() methods of
the Wave_read and Wave_write classes. They will be removed in Python
3.15.
@vstinner vstinner mentioned this issue May 31, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue May 31, 2023
@vstinner
[3.12] pythongh-105096: Reformat wave documentation (python#105136) (p…
6874b65 
…ython#105138)

pythongh-105096: Reformat wave documentation (python#105136)

Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
(cherry picked from commit 01b42f9)
vstinner added a commit that referenced this issue May 31, 2023
@vstinner
[3.11] gh-105096: Reformat wave documentation (#105136) (#105138) (#1…
5de6ca5 
…05155)

[3.12] gh-105096: Reformat wave documentation (#105136) (#105138)

gh-105096: Reformat wave documentation (#105136)

Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
(cherry picked from commit 01b42f9)
@erlend-aasland erlend-aasland mentioned this issue Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner